[GitHub] [pulsar] sijie commented on a change in pull request #4539: [Pulsar-Client] Add Producer Builder API Numeric Properties Validations

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4539: [Pulsar-Client] Add Producer Builder API Numeric Properties Validations
URL: https://github.com/apache/pulsar/pull/4539#discussion_r300874678
 
 

 ##########
 File path: pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/ProducerConfiguration.java
 ##########
 @@ -101,7 +101,7 @@ public long getSendTimeoutMs() {
      *            the time unit of the {@code sendTimeout}
      */
     public ProducerConfiguration setSendTimeout(int sendTimeout, TimeUnit unit) {
-        checkArgument(sendTimeout >= 0);
+        checkArgument(sendTimeout >= 0, "sendTimeout needs to be >= 0");
 
 Review comment:
   it seems that you moved the validations to ProducerConfigurationData for other methods. doesn't it make sense to move this method as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services