You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/04 10:53:04 UTC

[GitHub] [apisix] tzssangglass commented on pull request #8148: feat(openid-connect): expose unauth_action parameter in lua-resty-openidc

tzssangglass commented on PR #8148:
URL: https://github.com/apache/apisix/pull/8148#issuecomment-1303255049

   > Would adding tests for this feature be required?
   
   yes, we need to add test cases to cover this.
   
   > I also see some CI checks failing, but it seems unrelated to this change. Could you confirm?
   
   I checked and confirmed that it was related to your commit, as the error was running `t/plugin/openid-connect.t`. ref: https://github.com/apache/apisix/actions/runs/3385510161/jobs/5634897421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org