You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/02/19 12:28:41 UTC
[incubator-echarts] branch master updated: fix(toolbox): only
change title of requested feature. closes #12162
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 4f0ec36 fix(toolbox): only change title of requested feature. closes #12162
new 331ac4a Merge pull request #12168 from nsmgr8/toolbox-title-12162
4f0ec36 is described below
commit 4f0ec36d3b3ff98c7cfad36854be5a8f587d0673
Author: M Nasimul Haque <na...@biocarbonengineering.com>
AuthorDate: Tue Feb 18 19:23:29 2020 +0000
fix(toolbox): only change title of requested feature. closes #12162
---
src/component/toolbox/ToolboxView.js | 2 +-
src/component/toolbox/feature/MagicType.js | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/component/toolbox/ToolboxView.js b/src/component/toolbox/ToolboxView.js
index 25b079e..fa6c616 100644
--- a/src/component/toolbox/ToolboxView.js
+++ b/src/component/toolbox/ToolboxView.js
@@ -64,7 +64,7 @@ export default echarts.extendComponentView({
var feature;
// FIX#11236, merge feature title from MagicType newOption. TODO: consider seriesIndex ?
- if (payload && payload.newTitle != null) {
+ if (payload && payload.newTitle != null && payload.featureName === featureName) {
featureOpt.title = payload.newTitle;
}
diff --git a/src/component/toolbox/feature/MagicType.js b/src/component/toolbox/feature/MagicType.js
index 326db37..abd3615 100644
--- a/src/component/toolbox/feature/MagicType.js
+++ b/src/component/toolbox/feature/MagicType.js
@@ -180,7 +180,8 @@ proto.onclick = function (ecModel, api, type) {
type: 'changeMagicType',
currentType: type,
newOption: newOption,
- newTitle: newTitle
+ newTitle: newTitle,
+ featureName: 'magicType'
});
};
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org