You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/09/23 19:01:45 UTC
[PR] feat(goal): add durable native Goal continuation plugin [maka]
me2seeks opened a new pull request, #5649:
URL: https://github.com/apache/maka/pull/5649
## Summary
Add statically linked `maka.goal`: a Profile owner, `GoalStatus` Agent tool, Session-bound Remote methods and a separate Desktop Session Inspector Client.
- Save/start, pause/resume, cancel and mark complete, with Goal ID + revision controls and immutable terminal outcomes.
- Persist immutable submission intents before Host admission; use original operation IDs for retries and restart reconciliation. Host retains execution, authorization and accounting ownership.
- Apply exact-invocation model reports only after normal completion; continue within a finite iteration limit. Handle revoked grants, incognito, sealed handoff pauses and unknown cancellation without submitting replacement work or indefinitely pinning idle Host.
- Optional observed **Session** token threshold includes other Session activity since creation. Missing usage stops continuation. This is not a hard token/request/aggregate-step cap.
Saved goals require explicit start. This version does not implement legacy `goal.*` RPCs, automatic adoption of user Turns, an independent evaluator, or automatic Host handoff resume. Unknown cancelled admission retains its original pending identity and blocks replacement until reconciled. See `crates/goal/README.md` for precise controls and recovery semantics.
## Verification
- `cargo test -p maka-goal --lib`: 6 passed (lost commit reply, exact retry, stale CAS, immutable outbox, bounded iterations, missing usage, terminal monotonicity, usage failure, handoff and keepalive policy).
- `cargo test -p maka-runtime-host --test integration goal_plugin -- --nocapture`: passed across three Host lifetimes. Covers actual model continuation and GoalStatus, persistent consent, pause/resume, completion after settlement, stale controls, budget stop, grant revocation/renewal, exact cancellation, retirement and recovery of an interrupted accepted execution.
- The Host fixture restores a dispatch commitment with no receipt, verifies `cancellation_unknown` without a new provider request, closes its client and confirms `Host::wait_until_idle` completes.
- `cargo clippy -p maka-goal --all-targets -- -D warnings`, `cargo fmt --all`, strict standalone Client TypeScript, Biome, dependency inventory/license check and `git diff --check`: passed.
- Actual Client browser preview with mock Remote: lost arm reply → retry used the same UUID `a3845295-a617-4c8a-8822-7a49f2285817`; pause then sent that Goal ID and revision 1. The UI showed paused state and enabled resume. Local screenshot captured. This is not a full Electron test.
- Full repository suites were not run.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex implementation/verification; GPT-6 Luna independent Host state/recovery and Client/Remote audits. Audit findings were used to add terminal monotonicity, cancellation-unknown idle behavior, handoff handling and settlement despite usage failure.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(goal): add durable native Goal continuation plugin [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5649:
URL: https://github.com/apache/maka/pull/5649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org