[GitHub] [druid] jihoonson commented on a change in pull request #9183: fix topn aggregation on numeric columns with null values

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9183: fix topn aggregation on numeric columns with null values
URL: https://github.com/apache/druid/pull/9183#discussion_r368104265
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/topn/BaseTopNAlgorithm.java
 ##########
 @@ -79,7 +78,7 @@ public void run(
       @Nullable TopNQueryMetrics queryMetrics
   )
   {
-    if (params.getCardinality() != TopNColumnSelectorStrategy.CARDINALITY_UNKNOWN) {
+    if (params.getCardinality() != TopNParams.CARDINALITY_UNKNOWN) {
 
 Review comment:
   nit: I wish someday we could remove duplicate static values for this..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org