You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/01/07 23:09:22 UTC
[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #217: [YUNIKORN-501] Include node-selector and tolerations in the placeholder's pod spec.
yangwwei opened a new pull request #217:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #217: [YUNIKORN-501] Include node-selector and tolerations in the placeholder's pod spec.
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #217:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/217#issuecomment-759944518
Merging this to the dev branch. I will create a PR for the review before committing to the master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #217: [YUNIKORN-501] Include node-selector and tolerations in the placeholder's pod spec.
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #217:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #217: [YUNIKORN-501] Include node-selector and tolerations in the placeholder's pod spec.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #217:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/217#issuecomment-759871670
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=h1) Report
> Merging [#217](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=desc) (4314d00) into [YUNIKORN-2](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/132fdae007aa63aa18ff1b16a6846ec92d7d56d0?el=desc) (132fdae) will **decrease** coverage by `0.24%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## YUNIKORN-2 #217 +/- ##
==============================================
- Coverage 59.66% 59.41% -0.25%
==============================================
Files 35 35
Lines 3131 3129 -2
==============================================
- Hits 1868 1859 -9
- Misses 1182 1188 +6
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `53.06% <ø> (ø)` | |
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `77.27% <ø> (+3.35%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <ø> (-4.00%)` | :arrow_down: |
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `63.15% <ø> (ø)` | |
| [pkg/cache/placeholder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyLmdv) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=footer). Last update [132fdae...4314d00](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/217?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org