[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5987: HADOOP-18865 ABFS: Adding "100-continue" in userAgent String if enabled

["anmolanmol1234 (via GitHub)" <gi...@apache.org>]

anmolanmol1234 commented on code in PR #5987:
URL: https://github.com/apache/hadoop/pull/5987#discussion_r1307404077


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -751,6 +752,15 @@ public AbfsRestOperation append(final String path, final byte[] buffer,
       }
     }
 
+    // Check if the retry is with "Expect: 100-continue" header being present in the previous request.

Review Comment:
   "We are attempting to dynamically update the User-Agent header. The removal from the User-Agent would only be necessary if we are retrying the same append request that failed due to a user error. Consequently, the retry for the identical append request would occur without the 'Expect: 100-continue' header enabled." Hence the only way is to remove the string from the header. So even if we create a separate method that would have the same functionality. The other approach can be to add the string only if expectHeaderIsEnabled but since that is for each append request, it would need the userAgent header to be updated for each append request making the operation costly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org