[GitHub] [incubator-iceberg] edgarRd commented on a change in pull request #199: ORC metrics

[GitBox <gi...@apache.org>]

edgarRd commented on a change in pull request #199:
URL: https://github.com/apache/incubator-iceberg/pull/199#discussion_r429463646



##########
File path: parquet/src/test/java/org/apache/iceberg/parquet/TestParquetMetrics.java
##########
@@ -57,10 +78,133 @@ public File writeRecords(Schema schema, Map<String, String> properties, GenericD
     return ParquetWritingTestUtils.writeRecords(temp, schema, properties, records);
   }
 
-  @Override
-  public int splitCount(File parquetFile) throws IOException {
+  private int splitCount(File parquetFile) throws IOException {
     try (ParquetFileReader reader = ParquetFileReader.open(ParquetIO.file(localInput(parquetFile)))) {
       return reader.getRowGroups().size();
     }
   }
+
+  @Test
+  public void testMetricsForTopLevelWithMultipleRowGroup() throws Exception {

Review comment:
       What's the rationale for that? I think this test is specific to Parquet hence it does not need to be in the abstract `TestMetrics` since it used Parquet specifics like `PARQUET_ROW_GROUP_SIZE_BYTES`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org