You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/05/17 06:13:26 UTC

[GitHub] [spark] advancedxy commented on pull request #41181: [SPARK-43504][K8S] Mounts the hadoop config map on the executor pod

advancedxy commented on PR #41181:
URL: https://github.com/apache/spark/pull/41181#issuecomment-1550797386

   > Thank you for making a PR, @turboFei .
   > 
   > However, this PR might cause a outage because the number of configMap is controlled by quota.
   > 
   > ```
   > $ kubectl describe quota | grep configmaps
   > count/configmaps                                                  4     150
   > ```
   > 
   > To avoid the production outage, this should be under a new configuration with `false` by default at least.
   
   150 is a bit small for serious production usage, we may add this note in the `running_on_k8s.md`  documentation.
   
   And BTW, this MR doesn't create new ConfigMaps, it either uses a user pre-set config map (no creation) or just reuse the config map created by driver which is created if necessary. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org