You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/06/17 08:24:59 UTC

[GitHub] [rocketmq] Jaskey opened a new pull request #2104: Fix NPE when receive empty body message.

Jaskey opened a new pull request #2104:
URL: https://github.com/apache/rocketmq/pull/2104


   ## What is the purpose of the change
   
   ISSUE #2102
   
   ## Brief changelog
   
   add null check for message body when calculate message size.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin commented on pull request #2104: [ISSUE #2102] Fix NPE when receive empty body message.

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2104:
URL: https://github.com/apache/rocketmq/pull/2104#issuecomment-651748972


   Plz name the pull request in the correct format next time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] zongtanghu commented on pull request #2104: Fix NPE when receive empty body message.

Posted by GitBox <gi...@apache.org>.
zongtanghu commented on pull request #2104:
URL: https://github.com/apache/rocketmq/pull/2104#issuecomment-645735610


   You just fix this issue in rocketmq-client.But this need users to update rocketmq-client. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls commented on pull request #2104: Fix NPE when receive empty body message.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2104:
URL: https://github.com/apache/rocketmq/pull/2104#issuecomment-645267877


   
   [![Coverage Status](https://coveralls.io/builds/31506514/badge)](https://coveralls.io/builds/31506514)
   
   Coverage decreased (-0.004%) to 51.197% when pulling **243ce11e9576562b0ea2c941c19a486b136a5c94 on Jaskey:dev/#2102-empty-body-npe** into **2fa51fc1bd3be4d31156f40854eaddcf2b790a6f on apache:develop**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Jaskey commented on pull request #2104: Fix NPE when receive empty body message.

Posted by GitBox <gi...@apache.org>.
Jaskey commented on pull request #2104:
URL: https://github.com/apache/rocketmq/pull/2104#issuecomment-647397793


   @zongtanghu better than nothing. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org