You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/06/08 20:57:27 UTC

[GitHub] tinkerpop pull request #874: TINKERPOP-1979 Fix math() on OLAP/Spark

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/874

    TINKERPOP-1979 Fix math() on OLAP/Spark

    https://issues.apache.org/jira/browse/TINKERPOP-1979
    
    Should be working now - just a serialization problem and fix to dealing with requirements for `PathProcessor` on `MathStep`. Note that you still can't access path labels with `math()` in OLAP after this fix or you will run afoul of standard behavior of `ComputerVerificationStrategy`. I think that's just a limitation of the overall design with OLAP and path.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1979

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/874.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #874
    
----
commit 9f8f3b61b8e69624b2ac7aac3c98dcace55a079f
Author: Stephen Mallette <sp...@...>
Date:   2018-06-08T16:50:00Z

    TINKERPOP-1979 Fixed OLAP bug with math() step
    
    math() can now execute in OLAP with by() modulators if the expression given to math() does not access path labels.

commit a6e0a2d55c6b5bb9a710a53b8dfc208696416fe2
Author: Stephen Mallette <sp...@...>
Date:   2018-06-08T20:53:30Z

    TINKERPOP-1979 Get math() working on spark properly
    
    The Expression class was not serializable and Spark was not happy. Wrapped it up in another class that was and now tests work on spark ok.

----


---

[GitHub] tinkerpop pull request #874: TINKERPOP-1979 Fix math() on OLAP/Spark

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/874


---

[GitHub] tinkerpop issue #874: TINKERPOP-1979 Fix math() on OLAP/Spark

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/874
  
    VOTE: +1


---

[GitHub] tinkerpop issue #874: TINKERPOP-1979 Fix math() on OLAP/Spark

Posted by robertdale <gi...@git.apache.org>.

Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/874
  
    VOTE +1


---