[jira] [Created] (ORC-836) StringGroupFromDoubleTreeReader Use Long.toString

["David Mollitor (Jira)" <ji...@apache.org>]

David Mollitor created ORC-836:
----------------------------------

             Summary: StringGroupFromDoubleTreeReader Use Long.toString
                 Key: ORC-836
                 URL: https://issues.apache.org/jira/browse/ORC-836
             Project: ORC
          Issue Type: Improvement
            Reporter: David Mollitor
            Assignee: David Mollitor


https://github.com/apache/orc/blob/fb0ed31f15d9b77b76bc5dec8721f5d9ee129879/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L1104-L1106

{code:java}
      if (!Double.isNaN(doubleValue)) {
        String string = String.valueOf(doubleValue);
        byte[] bytes = string.getBytes(StandardCharsets.UTF_8);
        assignStringGroupVectorEntry(bytesColVector, elementNum, readerType, bytes);
      }
{code}

{{String.valueOf}} simply calls {{Double.toString()}}, so just skip the jumps and call {{Double.toString()}} directly.

 Also, does not need to be {{UTF_8}}.  Will only ever be ASCI values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)