You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by chamilad <gi...@git.apache.org> on 2014/10/15 16:38:46 UTC

[GitHub] stratos pull request: Clean script kills all Java processes.

GitHub user chamilad opened a pull request:

    https://github.com/apache/stratos/pull/93

    Clean script kills all Java processes.

    This fix allows the clean script to filter the java processes by Carbon start string and ActiveMQ string

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamilad/stratos cleanscript_imp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #93
    
----
commit 5c636606a10179491848134fd84326d483b16089
Author: Chamila de Alwis <ch...@wso2.com>
Date:   2014-10-15T14:37:16Z

    Clean script kills all Java processes.
    This fix allows the clean script to filter the java processes by Carbon start string and ActiveMQ string

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Clean script kills all Java processes.

Posted by chamilad <gi...@git.apache.org>.

Github user chamilad commented on the pull request:

    https://github.com/apache/stratos/pull/93#issuecomment-60042465
  
    @imesh 
    
    Thanks for the suggestion. This is possible to do since ActiveMQ has its pid stored in a pid file inside the data directory. We can store that and the pid's from the Carbon servers. I will come up with a PR soon. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Clean script kills all Java processes.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/stratos/pull/93


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Clean script kills all Java processes.

Posted by imesh <gi...@git.apache.org>.

Github user imesh commented on the pull request:

    https://github.com/apache/stratos/pull/93#issuecomment-59599713
  
    Great work! I still think we can improve this further by keeping the process ids at the server startup and use them to execute the termination process. Otherwise there could be other servers that users run in the same host which will fall under these queries.
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---