[GitHub] [james-project] jeantil commented on a change in pull request #291: JAMES-3500 Fasten tests with reuseForks

[GitBox <gi...@apache.org>]

jeantil commented on a change in pull request #291:
URL: https://github.com/apache/james-project/pull/291#discussion_r634408214



##########
File path: backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java
##########
@@ -115,6 +116,18 @@ private void grantPermissionToTestingUser(Cluster privilegedCluster, String keys
         DockerfileBuilder applyStep(DockerfileBuilder builder);
     }
 
+    /**
+     * @return a string to append to image names in order to avoid conflict with concurrent builds
+     */

Review comment:
       at the moment you have the opposite behavior where you can set BUILD_ID env variable and it will use a fixed image ... most CI platform I know use the `CI` env variable to let code know it is being run on CI, you could use that I guess. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org