You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Valentin Kulichenko <va...@gmail.com> on 2016/12/20 23:27:23 UTC

Node attribute filter

Guys,

I created a simple implementation of IgnitePredicate<ClusterNode> based on
user attributes. This is the most commonly used approach for node filters,
but currently users are forced to create their own implementations each
time. Would be useful to have it out of the box.

Can someone take a look at the implementation and tell me if there is
anything wrong/missed?

Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
PR: https://github.com/apache/ignite/pull/1369

-Val

Re: Node attribute filter

Posted by Valentin Kulichenko <va...@gmail.com>.

Thanks, Denis! Will merge shortly.

On Thu, Dec 22, 2016 at 11:55 AM, Denis Magda <dm...@apache.org> wrote:

> Val, thanks. Reviewed. Looks good to merge.
>
> —
> Denis
>
> > On Dec 20, 2016, at 3:27 PM, Valentin Kulichenko <
> valentin.kulichenko@gmail.com> wrote:
> >
> > Guys,
> >
> > I created a simple implementation of IgnitePredicate<ClusterNode> based
> on
> > user attributes. This is the most commonly used approach for node
> filters,
> > but currently users are forced to create their own implementations each
> > time. Would be useful to have it out of the box.
> >
> > Can someone take a look at the implementation and tell me if there is
> > anything wrong/missed?
> >
> > Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
> > PR: https://github.com/apache/ignite/pull/1369
> >
> > -Val
>
>

Re: Node attribute filter

Posted by Denis Magda <dm...@apache.org>.

Val, thanks. Reviewed. Looks good to merge.

—
Denis

> On Dec 20, 2016, at 3:27 PM, Valentin Kulichenko <va...@gmail.com> wrote:
> 
> Guys,
> 
> I created a simple implementation of IgnitePredicate<ClusterNode> based on
> user attributes. This is the most commonly used approach for node filters,
> but currently users are forced to create their own implementations each
> time. Would be useful to have it out of the box.
> 
> Can someone take a look at the implementation and tell me if there is
> anything wrong/missed?
> 
> Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
> PR: https://github.com/apache/ignite/pull/1369
> 
> -Val