Re: [PR] CASSANDRA-19744 Accord migration and interop correctness [cassandra]

["aweisberg (via GitHub)" <gi...@apache.org>]

aweisberg commented on code in PR #3395:
URL: https://github.com/apache/cassandra/pull/3395#discussion_r1706010997


##########
src/java/org/apache/cassandra/service/accord/api/AccordAgent.java:
##########
@@ -122,7 +122,7 @@ public long preAcceptTimeout()
     @Override
     public Txn emptyTxn(Kind kind, Seekables<?, ?> seekables)
     {
-        return new Txn.InMemory(kind, seekables, TxnRead.EMPTY, TxnQuery.EMPTY, null);
+        return new Txn.InMemory(kind, seekables, TxnRead.EMPTY, TxnQuery.UNSAFE_EMPTY, null);

Review Comment:
   Will rename it to `emptySystemTxn` and add commments. Will also update the tests to stop using this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org