You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/12/18 21:27:24 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #5386: Add a second origin server to CDN in a Box
zrhoffman opened a new pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
This PR
- [x] is not related to any Issue <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
- Renames the CDN in a Box `origin` server to `origin-01`
- Adds an `origin-02` server to CDN in a Box
- Enables the multi-site origin feature for CDN in a Box's `demo1` delivery service (was meant to be done in #5164)
- Fixes a bug where the Traffic Ops server objects for CiaB's origin server did not include an IPv6 address because the BusyBox implementation of the `route` command that Alpine uses by default does not include the `-6` flag. Fixed by installing the actual `route` command.
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- CDN in a Box
- Documentation
- Traffic Ops (v1 API tests)
- CI tests
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
- Run CDN in a Box, make sure the readiness container exits successfully
- Build the documentation
- Check the result of the *CDN-in-a-Box CI* workflow
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
For the origin `route` command fix:
- master
- 5.0.0 (RC5)
- 4.1.1
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [x] This PR includes documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #5386: Add a second origin server to CDN in a Box
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386#issuecomment-748342647
The origin servers run on a 26.1MB Alpine-based image. I can understand wanting to avoid adding big, bulky things to CDN in a Box, but that's not what this.
Also, servers queue for enrollment in parallel, so the additional startup time added by this PR is the time that a single POST request takes, a fraction of a second.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on pull request #5386: Add a second origin server to CDN in a Box
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386#issuecomment-748349207
Having a second origin server in CiaB is not so important to me. PRed the bugfixes that this PR included in #5388, and closing this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5386: Add a second origin server to CDN in a Box
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386#issuecomment-748340203
CDN-in-a-Box is getting pretty large... I, personally, think it ought to be kept to the absolute minimum to get a working CDN running. That was the original intention. It does support loading (somewhat) arbitrary data sets for testing purposes, but honestly I think it's high time we revisited the idea of splitting it into two. One setup for dev/demo and another for testing that can be more expansive. As a developer, I want CiaB to spin up fast and use the smallest amount of resources possible. Every new service we add impacts those two desires to some degree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman closed pull request #5386: Add a second origin server to CDN in a Box
Posted by GitBox <gi...@apache.org>.
zrhoffman closed pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 edited a comment on pull request #5386: Add a second origin server to CDN in a Box
Posted by GitBox <gi...@apache.org>.
ocket8888 edited a comment on pull request #5386:
URL: https://github.com/apache/trafficcontrol/pull/5386#issuecomment-748340203
CDN-in-a-Box is getting pretty large... I, personally, think it ought to be kept to the absolute, simplest minimum to get a working CDN running. That was the original intention. It does support loading (somewhat) arbitrary data sets for testing purposes, but honestly I think it's high time we revisited the idea of splitting it into two. One setup for dev/demo and another for testing that can be more expansive. As a developer, I want CiaB to spin up fast and use the smallest amount of resources possible. Every new service we add impacts those two desires to some degree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org