You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by mf...@apache.org on 2014/07/21 20:46:20 UTC
[2/4] git commit: STREAMS-132 | Code review feedback
STREAMS-132 | Code review feedback
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/8cc3d699
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/8cc3d699
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/8cc3d699
Branch: refs/heads/master
Commit: 8cc3d69992d6f3754cccd6da7697782740aa6830
Parents: c7e7ad6
Author: Robert Douglas <rd...@w2odigital.com>
Authored: Mon Jul 14 14:47:35 2014 -0500
Committer: Robert Douglas <rd...@w2odigital.com>
Committed: Mon Jul 14 14:55:44 2014 -0500
----------------------------------------------------------------------
.../regex/AbstractRegexExtensionExtractor.java | 30 ++++++++------------
1 file changed, 12 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/8cc3d699/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java b/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
index 4289adf..0b45cf2 100644
--- a/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
+++ b/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
@@ -61,25 +61,19 @@ public abstract class AbstractRegexExtensionExtractor<T> implements StreamsProce
@Override
public List<StreamsDatum> process(StreamsDatum entry) {
- try {
- if (!(entry.getDocument() instanceof Activity)) {
- return Lists.newArrayList();
- }
- if (Strings.isNullOrEmpty(pattern)) {
- prepare(null);
- }
- Activity activity = (Activity) entry.getDocument();
- Map<String, List<Integer>> matches = RegexUtils.extractMatches(pattern, activity.getContent());
- Collection<T> entities = ensureTargetObject(activity);
- for (String key : matches.keySet()) {
- entities.add(prepareObject(key));
- }
- return Lists.newArrayList(entry);
- } catch (Throwable e) {
- LOGGER.error("Throwable process {}", e);
- e.printStackTrace();
- throw new RuntimeException(e);
+ if (!(entry.getDocument() instanceof Activity)) {
+ return Lists.newArrayList();
+ }
+ if (Strings.isNullOrEmpty(pattern)) {
+ prepare(null);
+ }
+ Activity activity = (Activity) entry.getDocument();
+ Map<String, List<Integer>> matches = RegexUtils.extractMatches(pattern, activity.getContent());
+ Collection<T> entities = ensureTargetObject(activity);
+ for (String key : matches.keySet()) {
+ entities.add(prepareObject(key));
}
+ return Lists.newArrayList(entry);
}
@Override