You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/06/23 12:36:12 UTC
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/956
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
ASTERIXDB-1499: remove incorrect Content-Length
Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/56/956/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 4376b22..35a780b 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -68,8 +68,7 @@
}
public enum Header {
- Accept("Accept"),
- ContentLength("Content-Length");
+ Accept("Accept");
private final String str;
@@ -334,7 +333,6 @@
GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, result);
//result = JSONUtil.indent(result);
- response.setIntHeader(Header.ContentLength.str(), result.length());
response.getWriter().print(result);
if (response.getWriter().checkError()) {
LOGGER.warning("Error flushing output writer");
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/956/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java:
Line 71: Accept("Accept");
> MAJOR SonarQube violation:
This is fixed in my branch, not fixing it here.
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has posted comments on this change.
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
Patch Set 1:
Manual testing with
select value "\u0647 \u062e\u0648\u0696\u0648\u064a";
shows the issue before applying this patch and it is fixed after this patch.
I'm working on running regression test though the QueryService API, but the framework is not done yet and so there are no regression tests as part of this change.
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/1728/
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: ASTERIXDB-1499: remove incorrect Content-Length
......................................................................
ASTERIXDB-1499: remove incorrect Content-Length
Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/956
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <bu...@gmail.com>
---
M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Yingyi Bu: Looks good to me, approved
Jenkins: Verified
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 4376b22..35a780b 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -68,8 +68,7 @@
}
public enum Header {
- Accept("Accept"),
- ContentLength("Content-Length");
+ Accept("Accept");
private final String str;
@@ -334,7 +333,6 @@
GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, result);
//result = JSONUtil.indent(result);
- response.setIntHeader(Header.ContentLength.str(), result.length());
response.getWriter().print(result);
if (response.getWriter().checkError()) {
LOGGER.warning("Error flushing output writer");
--
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2aaaa60b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>