[GitHub] [helix] junkaixue commented on a diff in pull request #2353: Implement direct child change listener in ZkMetaClient

["junkaixue (via GitHub)" <gi...@apache.org>]

junkaixue commented on code in PR #2353:
URL: https://github.com/apache/helix/pull/2353#discussion_r1090064049


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -258,7 +260,12 @@ public boolean subscribeDataChange(String key, DataChangeListener listener,
   public DirectChildSubscribeResult subscribeDirectChildChange(String key,
       DirectChildChangeListener listener, boolean skipWatchingNonExistNode,
       boolean persistListener) {

Review Comment:
   Since this API is not published. Can we change it? As we discussed, we will have new API to support persistent listener. Then we can get rid of this boolean option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org