You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/12/16 06:31:06 UTC

Review Request 16282: CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16282/
-----------------------------------------------------------

Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-5208
    https://issues.apache.org/jira/browse/CLOUDSTACK-5208


Repository: cloudstack-git


Description
-------

CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name

Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 in branch refs/heads/master part of code is commented which throws exception on not finding system vm template


Diffs
-----

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java c2630b0 

Diff: https://reviews.apache.org/r/16282/diff/


Testing
-------


Thanks,

Harikrishna Patnala

Re: Review Request 16282: CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name

Posted by Kishan Kavala <Ki...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16282/#review30686
-----------------------------------------------------------

Ship it!


4034aad250106eaaa85c7f57df12965c878fb2c1

- Kishan Kavala


On Dec. 16, 2013, 11:01 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16282/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 11:01 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5208
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5208
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name
> 
> Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 in branch refs/heads/master part of code is commented which throws exception on not finding system vm template
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java c2630b0 
> 
> Diff: https://reviews.apache.org/r/16282/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 16282: CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16282/#review30689
-----------------------------------------------------------


Commit 29b90e7a5c226f110a1f48de09a9b9c967c34f96 in branch refs/heads/master from Kishan Kavala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=29b90e7 ]

CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 Commented the exception.


- ASF Subversion and Git Services


On Dec. 16, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16282/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5208
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5208
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name
> 
> Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 in branch refs/heads/master part of code is commented which throws exception on not finding system vm template
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java c2630b0 
> 
> Diff: https://reviews.apache.org/r/16282/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>

Re: Review Request 16282: CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16282/#review30685
-----------------------------------------------------------


Commit 4034aad250106eaaa85c7f57df12965c878fb2c1 in branch refs/heads/4.3 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4034aad ]

CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 Commented the exception. .


- ASF Subversion and Git Services


On Dec. 16, 2013, 5:31 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16282/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 5:31 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5208
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5208
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5208: upgrade from 3.0.6 to 4.3 is not throwing any exception if new System VM template is not registered with proper name
> 
> Commit ae231444bc885ee5e9a5d4bb3003bef651c849d6 in branch refs/heads/master part of code is commented which throws exception on not finding system vm template
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java c2630b0 
> 
> Diff: https://reviews.apache.org/r/16282/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>