You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2021/08/31 19:38:12 UTC
[GitHub] [royale-asjs] brianraymes opened a new pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
brianraymes opened a new pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147
Jewel SpinnerMouseController has two bugs where auto increment/decrement timers become unstoppable if one click drags off of the buttons (click and hold, drag off button, then let go). This change cancels the timers, if running, when the mouse moves away from the buttons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941
@brianraymes Are you still planning on making changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
brianraymes commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593
> @brianraymes Are you still planning on making changes to this PR?
Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-910153041
Looks good!
Is there a reason you used `mouseout` instead of `mouseleave`? I don't use Jewel, and I'm not sure what the structure is. Is there any chance of `mouseout` being fired when moving the mouse over a nested element?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
brianraymes commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-912713695
That's a great question. Primarily, because mouseleave was not modeled in MouseEvents, and I'm more familiar with Flex's older model. I'll take a look at mouseleave and test it out. If it works well, I'll add it in and update this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
brianraymes commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593
> @brianraymes Are you still planning on making changes to this PR?
Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941
@brianraymes Are you still planning on making changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] Harbs commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-957142941
@brianraymes Are you still planning on making changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [royale-asjs] brianraymes commented on pull request #1147: Jewel: Cancel spinner auto increment/decrement when mousing away from buttons
Posted by GitBox <gi...@apache.org>.
brianraymes commented on pull request #1147:
URL: https://github.com/apache/royale-asjs/pull/1147#issuecomment-958586593
> @brianraymes Are you still planning on making changes to this PR?
Yes! I will test out the other mouse event soon and update. Thank you for the reminder. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org