You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 14:37:23 UTC

[GitHub] [arrow] jcmuel opened a new pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for BUILD_WARNING_LEVEL == CHECKIN

jcmuel opened a new pull request #9266:
URL: https://github.com/apache/arrow/pull/9266


   See [Intel Compiler warning flag documentation](https://software.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/error-handling-1/warnings-errors-and-remarks.html).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for BUILD_WARNING_LEVEL == CHECKIN

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9266:
URL: https://github.com/apache/arrow/pull/9266#issuecomment-762888694


   Thank you for the PR @jcmuel ! Can you also make sure the two other `BUILD_WARNING_LEVEL` codepaths build fine?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for different warning levels

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9266:
URL: https://github.com/apache/arrow/pull/9266


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jcmuel commented on pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for BUILD_WARNING_LEVEL == CHECKIN

Posted by GitBox <gi...@apache.org>.
jcmuel commented on pull request #9266:
URL: https://github.com/apache/arrow/pull/9266#issuecomment-762898715


   I just added the missing code path, and adjusted the production code path, such that it uses "/Wall" on Intel for Windows. Not sure if this is necessary, but I did it for the sake of consistency with the other two code paths.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for different warning levels

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9266:
URL: https://github.com/apache/arrow/pull/9266#issuecomment-762923197


   https://issues.apache.org/jira/browse/ARROW-10489


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #9266: ARROW-10489: [C++] Add Intel C++ compiler options for different warning levels

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9266:
URL: https://github.com/apache/arrow/pull/9266#issuecomment-762899183


   Those warnings are mainly for development, but useful anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org