You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/21 09:14:04 UTC
[GitHub] [airflow] potiuk opened a new pull request #7793: Verify that all
providers packages are included
potiuk opened a new pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7793: Verify that all
providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7793: Verify
that all providers packages are included
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396103630
##########
File path: scripts/ci/_utils.sh
##########
@@ -38,6 +38,9 @@ function verbose_docker {
}
function initialize_breeze_environment {
+ # default python version
+ PYTHON_VERSION=${PYTHON_VERSION:="3.6"}
Review comment:
Should this go under `function setup_default_breeze_variables` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7793:
Verify that all providers packages are included
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396099421
##########
File path: scripts/ci/ci_prepare_packages.sh
##########
@@ -63,46 +93,12 @@ do
python3 setup_backport_packages.py "${BACKPORT_PACKAGE}" sdist bdist_wheel >/dev/null
done
-if [[ ${BUILD_COMMON_PROVIDERS_PACKAGE} == "true" ]]; then
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing backporting package providers (everything)"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup_backport_packages.py providers clean --all
- python3 setup_backport_packages.py providers sdist bdist_wheel >/dev/null
-fi
+DUMP_FILE="/tmp/airflow_provider_packages_$(date +"%Y%m%d-%H%M%S").tar.gz"
-popd || exit 1
+tar -cvzf "${DUMP_FILE}" "dist"
-cd "${MY_DIR}/../../" || exit 1
+echo "Packages are in dist bit also tar-gzipped in ${DUMP_FILE}"
-if [[ ${BUILD_AIRFLOW_PACKAGE} == "true" ]]; then
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing apache-airflow package"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup.py clean --all
- python3 setup.py sdist bdist_wheel >/dev/null
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing apache-airflow-pinned package"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup.py clean --all
- python3 setup.py pinned sdist bdist_wheel >/dev/null
-fi
Review comment:
Where is now the logic for building the package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0974aabd31abc6aeadf4f07c9c310b6750e28e2f&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
- Coverage 86.92% 86.54% -0.39%
==========================================
Files 924 924
Lines 44859 44859
==========================================
- Hits 38993 38822 -171
- Misses 5866 6037 +171
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.67% <0.00%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [0974aab...2dbe262](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/8c5638832f2b6507dd872d37f4a02d66f938d5fd?src=pr&el=desc) will **decrease** coverage by `0.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
=========================================
- Coverage 86.92% 86.42% -0.5%
=========================================
Files 924 924
Lines 44792 44792
=========================================
- Hits 38934 38713 -221
- Misses 5858 6079 +221
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [8c56388...19ce9e3](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7793: Verify that all
providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602220126
Should be fine now. I had three changes in one PR that I split and that was a bad ~merge~ split.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0974aabd31abc6aeadf4f07c9c310b6750e28e2f&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
- Coverage 86.92% 86.54% -0.39%
==========================================
Files 924 924
Lines 44859 44859
==========================================
- Hits 38993 38822 -171
- Misses 5866 6037 +171
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.67% <0.00%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [0974aab...2dbe262](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7793:
Verify that all providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396099880
##########
File path: scripts/ci/ci_prepare_packages.sh
##########
@@ -63,46 +93,12 @@ do
python3 setup_backport_packages.py "${BACKPORT_PACKAGE}" sdist bdist_wheel >/dev/null
done
-if [[ ${BUILD_COMMON_PROVIDERS_PACKAGE} == "true" ]]; then
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing backporting package providers (everything)"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup_backport_packages.py providers clean --all
- python3 setup_backport_packages.py providers sdist bdist_wheel >/dev/null
-fi
+DUMP_FILE="/tmp/airflow_provider_packages_$(date +"%Y%m%d-%H%M%S").tar.gz"
-popd || exit 1
+tar -cvzf "${DUMP_FILE}" "dist"
-cd "${MY_DIR}/../../" || exit 1
+echo "Packages are in dist bit also tar-gzipped in ${DUMP_FILE}"
-if [[ ${BUILD_AIRFLOW_PACKAGE} == "true" ]]; then
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing apache-airflow package"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup.py clean --all
- python3 setup.py sdist bdist_wheel >/dev/null
- echo
- echo "-----------------------------------------------------------------------------------"
- echo " Preparing apache-airflow-pinned package"
- echo "-----------------------------------------------------------------------------------"
- echo
- python3 setup.py clean --all
- python3 setup.py pinned sdist bdist_wheel >/dev/null
-fi
Review comment:
Good eye. Bad merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7793: Verify that all
providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [9ad1844...3276af8](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7793:
Verify that all providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396104679
##########
File path: scripts/ci/_utils.sh
##########
@@ -38,6 +38,9 @@ function verbose_docker {
}
function initialize_breeze_environment {
+ # default python version
+ PYTHON_VERSION=${PYTHON_VERSION:="3.6"}
Review comment:
https://github.com/apache/airflow/pull/7805/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0974aabd31abc6aeadf4f07c9c310b6750e28e2f&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
- Coverage 86.92% 86.54% -0.39%
==========================================
Files 924 924
Lines 44859 44859
==========================================
- Hits 38993 38822 -171
- Misses 5866 6037 +171
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.67% <0.00%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [0974aab...2dbe262](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0974aabd31abc6aeadf4f07c9c310b6750e28e2f&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
- Coverage 86.92% 86.54% -0.39%
==========================================
Files 924 924
Lines 44859 44859
==========================================
- Hits 38993 38822 -171
- Misses 5866 6037 +171
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0.00%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0.00%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0.00%> (-15.50%)` | :arrow_down: |
| [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.67% <0.00%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [0974aab...2dbe262](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7793:
Verify that all providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396103978
##########
File path: scripts/ci/_utils.sh
##########
@@ -38,6 +38,9 @@ function verbose_docker {
}
function initialize_breeze_environment {
+ # default python version
+ PYTHON_VERSION=${PYTHON_VERSION:="3.6"}
Review comment:
Not really. The name here is misleading - setup_default_breeze_variables is for breeze command. This one above initializes common environment that is used by both breeze and the CI scripts (CI scripts do no use Breeze as such - they share common methods with it). I will change the name to initialize_common_environment in a separate commit :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [9ad1844...3276af8](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7793: Verify
that all providers packages are included
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396104152
##########
File path: scripts/ci/_utils.sh
##########
@@ -38,6 +38,9 @@ function verbose_docker {
}
function initialize_breeze_environment {
+ # default python version
+ PYTHON_VERSION=${PYTHON_VERSION:="3.6"}
Review comment:
👍 Ya renaming it would be good, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [9ad1844...3276af8](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0.00%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [9ad1844...3276af8](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9ad1844d582f15b488d261ba80159dba388d7f8b?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `97.66% <0%> (+2.87%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [9ad1844...3276af8](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7793: Verify that all
providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602220126
Should be fine now. I had three changes in one PR that I split and that was a bad merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7793:
Verify that all providers packages are included
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#discussion_r396102441
##########
File path: scripts/ci/ci_prepare_packages.sh
##########
@@ -63,18 +95,6 @@ do
python3 setup_backport_packages.py "${BACKPORT_PACKAGE}" sdist bdist_wheel >/dev/null
done
-if [[ ${BUILD_COMMON_PROVIDERS_PACKAGE} == "true" ]]; then
Review comment:
BTW. We are getting rid of the common providers package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7793: Verify that
all providers packages are included
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7793: Verify that all providers packages are included
URL: https://github.com/apache/airflow/pull/7793#issuecomment-602187167
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=h1) Report
> Merging [#7793](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0974aabd31abc6aeadf4f07c9c310b6750e28e2f?src=pr&el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7793 +/- ##
==========================================
- Coverage 86.92% 86.54% -0.39%
==========================================
Files 924 924
Lines 44859 44859
==========================================
- Hits 38993 38822 -171
- Misses 5866 6037 +171
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `50.67% <0%> (-37.84%)` | :arrow_down: |
| [...roviders/google/cloud/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wb3N0Z3Jlc190b19nY3MucHk=) | `54.28% <0%> (-31.43%)` | :arrow_down: |
| [airflow/providers/postgres/hooks/postgres.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvaG9va3MvcG9zdGdyZXMucHk=) | `78.87% <0%> (-15.5%)` | :arrow_down: |
| [airflow/providers/mongo/hooks/mongo.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vaG9va3MvbW9uZ28ucHk=) | `93.15% <0%> (-4.11%)` | :arrow_down: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/7793/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `93.67% <0%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=footer). Last update [0974aab...2dbe262](https://codecov.io/gh/apache/airflow/pull/7793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services