You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2026/03/12 12:42:24 UTC

[PR] Remove remnants of `doWithWebDescriptor` [grails-core]

matrei opened a new pull request, #15500:
URL: https://github.com/apache/grails-core/pull/15500

   Also, clean up the javadoc in some classes related to Grails plugins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4091164309

   ## 🚨 TestLens detected 6 failed tests 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   | Check | Project/Task | Test | Runs |
   |---|---|---|---|
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, \#1] | ❌ |
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: \<org.grails.plugins.metadata.Test2\@79195c22\>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, \#1] | ❌ |
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, \#1] | ❌ |
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: \<org.grails.plugins.metadata.Test2\@1edfedf1\>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, \#1] | ❌ |
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, \#1] | ❌ |
   | [CI / Build Grails-Core \(macos-latest, 21\)](https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500) | :grails-test-suite-uber:test | GrailsPluginMetadataTests > returns plugins for instances > returns plugins for instances [instance: \<org.grails.plugins.metadata.Test2\@697a0948\>, name: dataBinding, \#1] | ❌ |
   
   🏷️ Commit: a4618118aa20af1ea648d62d71168fa8ce8e55f6
   ▶️ Tests:  5071 executed
   🟡 Checks: 22/32 completed
   
   ### Test Failures (first 5 of 6)
   
   <details>
   
   <summary><strong>GrailsPluginMetadataTests > returns plugin path for classes > returns plugin path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]</strong> (:grails-test-suite-uber:test in <a href="https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500">CI / Build Grails-Core (macos-latest, 21)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   path == expectedPath
   |    |  |
   ""   |  /plugins/data-binding-7.1.0-SNAPSHOT
        false
        36 differences (0% similarity)
        (------------------------------------)
        (/plugins/data-binding-7.1.0-SNAPSHOT)
   
   	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin path for classes(GrailsPluginMetadataTests.groovy:87)
   ```
   
   |expected|actual|
   |---|---|
   |<s>/plugins/data-binding-7.1.0-SNAPSHOT</s>||
   
   </details>
   <details>
   
   <summary><strong>GrailsPluginMetadataTests > returns plugin path for instances > returns plugin path for instances [instance: <or...@79195c22>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT, #1]</strong> (:grails-test-suite-uber:test in <a href="https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500">CI / Build Grails-Core (macos-latest, 21)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   path == expectedPath
   |    |  |
   ""   |  /plugins/data-binding-7.1.0-SNAPSHOT
        false
        36 differences (0% similarity)
        (------------------------------------)
        (/plugins/data-binding-7.1.0-SNAPSHOT)
   
   	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin path for instances(GrailsPluginMetadataTests.groovy:73)
   ```
   
   |expected|actual|
   |---|---|
   |<s>/plugins/data-binding-7.1.0-SNAPSHOT</s>||
   
   </details>
   <details>
   
   <summary><strong>GrailsPluginMetadataTests > returns plugin views path for classes > returns plugin views path for classes [clazz: class org.grails.plugins.metadata.Test2, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]</strong> (:grails-test-suite-uber:test in <a href="https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500">CI / Build Grails-Core (macos-latest, 21)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   viewsPath == expectedPath
   |         |  |
   null      |  /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views
             false
   
   	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin views path for classes(GrailsPluginMetadataTests.groovy:115)
   ```
   
   |expected|actual|
   |---|---|
   |<s>/plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views</s>|<b>null</b>|
   
   </details>
   <details>
   
   <summary><strong>GrailsPluginMetadataTests > returns plugin views path for instances > returns plugin views path for instances [instance: <or...@1edfedf1>, expectedPath: /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views, #1]</strong> (:grails-test-suite-uber:test in <a href="https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500">CI / Build Grails-Core (macos-latest, 21)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   viewsPath == expectedPath
   |         |  |
   null      |  /plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views
             false
   
   	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugin views path for instances(GrailsPluginMetadataTests.groovy:101)
   ```
   
   |expected|actual|
   |---|---|
   |<s>/plugins/data-binding-7.1.0-SNAPSHOT/grails-app/views</s>|<b>null</b>|
   
   </details>
   <details>
   
   <summary><strong>GrailsPluginMetadataTests > returns plugins for classes > returns plugins for classes [clazz: class org.grails.plugins.metadata.Test2, name: dataBinding, #1]</strong> (:grails-test-suite-uber:test in <a href="https://github.com/apache/grails-core/actions/runs/23302187598/job/67766277363?pr=15500">CI / Build Grails-Core (macos-latest, 21)</a>)</summary>
   
   ```
   Condition not satisfied:
   
   plugin?.name == name
   |       |    |  |
   null    null |  dataBinding
                false
   
   	at org.grails.plugins.metadata.GrailsPluginMetadataTests.returns plugins for classes(GrailsPluginMetadataTests.groovy:59)
   ```
   
   |expected|actual|
   |---|---|
   |<s>dataBinding</s>|<b>null</b>|
   
   </details>
   
   ### Muted Tests
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 GrailsPluginMetadataTests > returns plugin path for classes <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_3] -->
   🔲 GrailsPluginMetadataTests > returns plugin path for instances <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_2] -->
   🔲 GrailsPluginMetadataTests > returns plugin views path for classes <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_5] -->
   🔲 GrailsPluginMetadataTests > returns plugin views path for instances <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_4] -->
   🔲 GrailsPluginMetadataTests > returns plugins for classes <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_1] -->
   🔲 GrailsPluginMetadataTests > returns plugins for instances <!-- uniqueId=[engine:spock]/[spec:org.grails.plugins.metadata.GrailsPluginMetadataTests]/[feature:$spock_feature_0_0] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4092670439

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: e0aff6fe118230e64f367028d8509a1c0186610b
   ▶️ Tests:  0 executed
   ⚪️ Checks: 0/0 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei merged PR #15500:
URL: https://github.com/apache/grails-core/pull/15500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#discussion_r2960732453


##########
grails-core/src/main/groovy/grails/plugins/GrailsPluginManager.java:
##########
@@ -262,8 +260,8 @@ public interface GrailsPluginManager extends ApplicationContextAware {
     String getPluginPath(String name, boolean forceCamelCase);
 
     /**
-     * Looks up the plugin that defined the given instance. If no plugin
-     * defined the instance then null is returned.
+     * Looks up the plugin that defined the given instance.
+     * If no plugin is defined the instance, then null is returned.

Review Comment:
   Did a bigger overhaul of the javadoc in `GrailsPluginManager`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4150886559

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: c66160262fb5d64f3feaad9b4277dc76e6389cbb
   ▶️ Tests:  0 executed
   🟡 Checks: 0/29 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#discussion_r2956546156


##########
grails-core/src/main/groovy/grails/plugins/GrailsPluginManager.java:
##########
@@ -262,8 +260,8 @@ public interface GrailsPluginManager extends ApplicationContextAware {
     String getPluginPath(String name, boolean forceCamelCase);
 
     /**
-     * Looks up the plugin that defined the given instance. If no plugin
-     * defined the instance then null is returned.
+     * Looks up the plugin that defined the given instance.
+     * If no plugin is defined the instance, then null is returned.

Review Comment:
   minor, but maybe one of these: 
   
   - "If no plugin defined the instance, then null is returned." (keep original active voice)
   - "If no plugin is defined for the instance, then null is returned."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4091199790

   The `GrailsPluginMetadataTests` needs #15518 to be merged first to succeed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4085931169

   <!-- Bito Reply -->
   The second option is clearer and more precise, as 'no plugin is defined for the instance' better conveys that no plugin exists to handle it, compared to the ambiguous 'no plugin defined the instance.'


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4151008577

   @matrei can you please update this PR now that the other is merged so the tests show clean? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4151143883

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: 795014eac3758aed42ba4e61ef0052b557609fbc
   ▶️ Tests:  0 executed
   🟡 Checks: 0/30 completed
   
   ---
   _Learn more about TestLens at [testlens.app](https://testlens.app)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove remnants of `doWithWebDescriptor` [grails-core]

Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on PR #15500:
URL: https://github.com/apache/grails-core/pull/15500#issuecomment-4152928787

   > @matrei can you please update this PR now that the other is merged so the tests show clean?
   
   @jdaugherty The PR is now updated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org