You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org> on 2023/04/06 13:31:55 UTC
[GitHub] [hudi] yesemsanthoshkumar opened a new pull request, #8399: HUDI-4630
yesemsanthoshkumar opened a new pull request, #8399:
URL: https://github.com/apache/hudi/pull/8399
### Change Logs
Follow up of https://github.com/apache/hudi/pull/6726
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541199104
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0498fdb6655623313bfd26b716d34516b622791 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932)
* daada3f20792abfc8f8b088488cf75cd44f7c0bc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541415502
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daada3f20792abfc8f8b088488cf75cd44f7c0bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541205543
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0498fdb6655623313bfd26b716d34516b622791 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932)
* daada3f20792abfc8f8b088488cf75cd44f7c0bc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yesemsanthoshkumar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org>.
yesemsanthoshkumar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1543407086
@bvaradar All checks have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yesemsanthoshkumar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org>.
yesemsanthoshkumar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1521191274
> @yesemsanthoshkumar : Pinging to see if you can look at failing tests and rebase to latest master
@bvaradar Unfortunately, I can't work on it for atleast a month. Feel free to pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: HUDI-4630
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1499134607
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3318a2dc01303e79f370fc18135410f631aa7ca5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537765273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 201246664a237a780795e99897a584eab25b3ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914)
* b0498fdb6655623313bfd26b716d34516b622791 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1514042415
@yesemsanthoshkumar : Can you look at the failing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yesemsanthoshkumar commented on a diff in pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org>.
yesemsanthoshkumar commented on code in PR #8399:
URL: https://github.com/apache/hudi/pull/8399#discussion_r1192470009
##########
hudi-utilities/src/test/resources/delta-streamer-config/short_trip_uber_config.properties:
##########
@@ -25,3 +25,4 @@ hoodie.datasource.hive_sync.table=short_trip_uber_hive_dummy_table
hoodie.datasource.write.keygenerator.class=org.apache.hudi.utilities.deltastreamer.TestHoodieDeltaStreamer$TestTableLevelGenerator
hoodie.deltastreamer.schemaprovider.registry.baseUrl=http://localhost:8081/subjects/
hoodie.deltastreamer.schemaprovider.registry.urlSuffix=-value/versions/latest
+hoodie.deltastreamer.transformer.class=org.apache.hudi.utilities.transform.SqlFileBasedTransformer
Review Comment:
@boneanxs Where do you see these errors? I could see all tests passed before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537952737
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b0498fdb6655623313bfd26b716d34516b622791 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537758089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 201246664a237a780795e99897a584eab25b3ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914)
* b0498fdb6655623313bfd26b716d34516b622791 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #8399:
URL: https://github.com/apache/hudi/pull/8399#discussion_r1193140118
##########
hudi-utilities/src/test/resources/delta-streamer-config/short_trip_uber_config.properties:
##########
@@ -25,3 +25,4 @@ hoodie.datasource.hive_sync.table=short_trip_uber_hive_dummy_table
hoodie.datasource.write.keygenerator.class=org.apache.hudi.utilities.deltastreamer.TestHoodieDeltaStreamer$TestTableLevelGenerator
hoodie.deltastreamer.schemaprovider.registry.baseUrl=http://localhost:8081/subjects/
hoodie.deltastreamer.schemaprovider.registry.urlSuffix=-value/versions/latest
+hoodie.deltastreamer.transformer.class=org.apache.hudi.utilities.transform.SqlFileBasedTransformer
Review Comment:
This is a misconfig - this transformer needs other config to work properly, without which it'll break table creation for the failing testcases. Fixing it here https://github.com/apache/hudi/pull/8705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: HUDI-4630
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1499490232
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3318a2dc01303e79f370fc18135410f631aa7ca5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541478447
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
}, {
"hash" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16992",
"triggerID" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daada3f20792abfc8f8b088488cf75cd44f7c0bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985)
* 0bd50c0f76774af29fab8f28a2e16062656e9da6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16992)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] boneanxs commented on a diff in pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on code in PR #8399:
URL: https://github.com/apache/hudi/pull/8399#discussion_r1192151738
##########
hudi-utilities/src/test/resources/delta-streamer-config/short_trip_uber_config.properties:
##########
@@ -25,3 +25,4 @@ hoodie.datasource.hive_sync.table=short_trip_uber_hive_dummy_table
hoodie.datasource.write.keygenerator.class=org.apache.hudi.utilities.deltastreamer.TestHoodieDeltaStreamer$TestTableLevelGenerator
hoodie.deltastreamer.schemaprovider.registry.baseUrl=http://localhost:8081/subjects/
hoodie.deltastreamer.schemaprovider.registry.urlSuffix=-value/versions/latest
+hoodie.deltastreamer.transformer.class=org.apache.hudi.utilities.transform.SqlFileBasedTransformer
Review Comment:
@yesemsanthoshkumar Looks there are test failures:
```java
2023-05-10T10:02:49.3996412Z [ERROR] Errors:
2023-05-10T10:02:49.4001259Z [ERROR] TestHoodieMultiTableDeltaStreamer.testMultiTableExecutionWithKafkaSource:187 » NullPointer
2023-05-10T10:02:49.4002065Z [ERROR] TestHoodieMultiTableDeltaStreamer.testMultiTableExecutionWithParquetSource:231->syncAndVerify:300 » NullPointer
```
Relate to this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar merged PR #8399:
URL: https://github.com/apache/hudi/pull/8399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: HUDI-4630
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1499121795
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3318a2dc01303e79f370fc18135410f631aa7ca5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yesemsanthoshkumar commented on a diff in pull request #8399: HUDI-4630
Posted by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org>.
yesemsanthoshkumar commented on code in PR #8399:
URL: https://github.com/apache/hudi/pull/8399#discussion_r1159807786
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieMultiTableDeltaStreamer.java:
##########
@@ -75,6 +75,17 @@ static HoodieMultiTableDeltaStreamer.Config getConfig(String fileName, String co
}
}
+ @Test
+ public void testEmptyTransformerProps() throws IOException {
Review Comment:
@bvaradar Could you review this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537355300
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3318a2dc01303e79f370fc18135410f631aa7ca5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175)
* 201246664a237a780795e99897a584eab25b3ee5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537365399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 201246664a237a780795e99897a584eab25b3ee5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yesemsanthoshkumar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "yesemsanthoshkumar (via GitHub)" <gi...@apache.org>.
yesemsanthoshkumar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1540061914
@bvaradar Have updated the PR and rebased it as well. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1521116671
@yesemsanthoshkumar : Pinging to see if you can look at failing tests and rebase to latest master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1537356629
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3318a2dc01303e79f370fc18135410f631aa7ca5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175)
* 201246664a237a780795e99897a584eab25b3ee5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1542031250
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
}, {
"hash" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16992",
"triggerID" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bd50c0f76774af29fab8f28a2e16062656e9da6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16992)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541371547
Waiting for test to succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8399:
URL: https://github.com/apache/hudi/pull/8399#issuecomment-1541429032
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16175",
"triggerID" : "3318a2dc01303e79f370fc18135410f631aa7ca5",
"triggerType" : "PUSH"
}, {
"hash" : "201246664a237a780795e99897a584eab25b3ee5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16914",
"triggerID" : "201246664a237a780795e99897a584eab25b3ee5",
"triggerType" : "PUSH"
}, {
"hash" : "b0498fdb6655623313bfd26b716d34516b622791",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16932",
"triggerID" : "b0498fdb6655623313bfd26b716d34516b622791",
"triggerType" : "PUSH"
}, {
"hash" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985",
"triggerID" : "daada3f20792abfc8f8b088488cf75cd44f7c0bc",
"triggerType" : "PUSH"
}, {
"hash" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0bd50c0f76774af29fab8f28a2e16062656e9da6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daada3f20792abfc8f8b088488cf75cd44f7c0bc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16985)
* 0bd50c0f76774af29fab8f28a2e16062656e9da6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] boneanxs commented on a diff in pull request #8399: [HUDI-4630] Add transformer capability to individual feeds in MultiTableDeltaStreamer
Posted by "boneanxs (via GitHub)" <gi...@apache.org>.
boneanxs commented on code in PR #8399:
URL: https://github.com/apache/hudi/pull/8399#discussion_r1192151738
##########
hudi-utilities/src/test/resources/delta-streamer-config/short_trip_uber_config.properties:
##########
@@ -25,3 +25,4 @@ hoodie.datasource.hive_sync.table=short_trip_uber_hive_dummy_table
hoodie.datasource.write.keygenerator.class=org.apache.hudi.utilities.deltastreamer.TestHoodieDeltaStreamer$TestTableLevelGenerator
hoodie.deltastreamer.schemaprovider.registry.baseUrl=http://localhost:8081/subjects/
hoodie.deltastreamer.schemaprovider.registry.urlSuffix=-value/versions/latest
+hoodie.deltastreamer.transformer.class=org.apache.hudi.utilities.transform.SqlFileBasedTransformer
Review Comment:
Looks there's test failure:
```java
2023-05-10T10:02:49.3996412Z [ERROR] Errors:
2023-05-10T10:02:49.4001259Z [ERROR] TestHoodieMultiTableDeltaStreamer.testMultiTableExecutionWithKafkaSource:187 » NullPointer
2023-05-10T10:02:49.4002065Z [ERROR] TestHoodieMultiTableDeltaStreamer.testMultiTableExecutionWithParquetSource:231->syncAndVerify:300 » NullPointer
```
Relate to this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org