You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ksobrenat32 (via GitHub)" <gi...@apache.org> on 2025/09/26 14:44:35 UTC
[PR] Set latest tag based on branch in sdk and docker snapshots [beam]
ksobrenat32 opened a new pull request, #36298:
URL: https://github.com/apache/beam/pull/36298
This pull request updates the GitHub Actions workflows responsible for publishing Beam SDK and runner Docker images. The main goal is to ensure that the "latest" Docker tag is only applied when building from the `master` branch, preventing non-master branches from overwriting the "latest" tag, fixes #24130 .
A step was added to set the `LATEST_TAG` variable to `,latest` only when the workflow runs on the `master` branch, ensuring the "latest" tag is only used in that context. Outside of `master` it uses only the commit SHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #36298:
URL: https://github.com/apache/beam/pull/36298#issuecomment-3339022822
> [!NOTE]
> Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "ksobrenat32 (via GitHub)" <gi...@apache.org>.
ksobrenat32 commented on PR #36298:
URL: https://github.com/apache/beam/pull/36298#issuecomment-3339087885
I also see the [workflow](https://github.com/apache/beam/actions?query=workflow%3A%22Publish%20Docker%20Snapshots%22%20) has been failing, it looks like it has to do with the time limit, I will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #36298:
URL: https://github.com/apache/beam/pull/36298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36298:
URL: https://github.com/apache/beam/pull/36298#issuecomment-3339095599
Assigning reviewers:
R: @damccorm for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #36298:
URL: https://github.com/apache/beam/pull/36298#discussion_r2383132412
##########
.github/workflows/beam_Publish_Docker_Snapshots.yml:
##########
@@ -70,6 +70,13 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
+ - name: Set docker_tag_list
+ run: |
+ if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
+ echo "DOCKER_TAG_LIST=${{ github.sha }},latest" >> $GITHUB_ENV
+ else
+ echo "DOCKER_TAG_LIST=${{ github.sha }}" >> $GITHUB_ENV
+ fi
Review Comment:
Can we update this to use the same conditional logic as the other workflow? It seems cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Set latest tag based on branch in sdk and docker snapshots [beam]
Posted by "ksobrenat32 (via GitHub)" <gi...@apache.org>.
ksobrenat32 commented on code in PR #36298:
URL: https://github.com/apache/beam/pull/36298#discussion_r2383253740
##########
.github/workflows/beam_Publish_Docker_Snapshots.yml:
##########
@@ -70,6 +70,13 @@ jobs:
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- name: Setup environment
uses: ./.github/actions/setup-environment-action
+ - name: Set docker_tag_list
+ run: |
+ if [[ "${{ github.ref }}" == "refs/heads/master" ]]; then
+ echo "DOCKER_TAG_LIST=${{ github.sha }},latest" >> $GITHUB_ENV
+ else
+ echo "DOCKER_TAG_LIST=${{ github.sha }}" >> $GITHUB_ENV
+ fi
Review Comment:
Done :)
Now all the images are tagged with the sha by default but latest just when working on main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org