You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by lazyman500 <gi...@git.apache.org> on 2015/02/02 15:11:52 UTC
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
GitHub user lazyman500 opened a pull request:
https://github.com/apache/spark/pull/4310
[SPARK-5527] Improvements to standalone doc -explain how to sync cluster conf file
Improvements to standalone doc -explain how to sync cluster conf file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lazyman500/spark SPARK-5527
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4310
----
commit 188a90bb5920b46a487af7e8822ebe1f68d0591c
Author: lazymam500 <la...@gmail.com>
Date: 2015-02-02T14:02:55Z
Update spark-standalone.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4310#discussion_r24076227
--- Diff: docs/spark-standalone.md ---
@@ -93,6 +93,10 @@ You can optionally configure the cluster further by setting environment variable
<table class="table">
<tr><th style="width:21%">Environment Variable</th><th>Meaning</th></tr>
<tr>
+ <td><code>SPARK_MASTER</code></td>
--- End diff --
This property is not specifically about configuration files, and is deprecated. You would set `--master` now. That's why I say documenting it doesn't sound like the right thing, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by lazyman500 <gi...@git.apache.org>.
Github user lazyman500 closed the pull request at:
https://github.com/apache/spark/pull/4310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4310#issuecomment-72463329
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by lazyman500 <gi...@git.apache.org>.
Github user lazyman500 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4310#discussion_r24060365
--- Diff: docs/spark-standalone.md ---
@@ -93,6 +93,10 @@ You can optionally configure the cluster further by setting environment variable
<table class="table">
<tr><th style="width:21%">Environment Variable</th><th>Meaning</th></tr>
<tr>
+ <td><code>SPARK_MASTER</code></td>
--- End diff --
Thanks for giving suggestion. Configuration file synchronization is a very common requirement, why not recommend? Do we need add some comment to explain it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4310#discussion_r23979658
--- Diff: docs/spark-standalone.md ---
@@ -93,6 +93,10 @@ You can optionally configure the cluster further by setting environment variable
<table class="table">
<tr><th style="width:21%">Environment Variable</th><th>Meaning</th></tr>
<tr>
+ <td><code>SPARK_MASTER</code></td>
--- End diff --
Isn't this deprecated though? I don't know that this is supposed to be documented.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by lazyman500 <gi...@git.apache.org>.
Github user lazyman500 commented on the pull request:
https://github.com/apache/spark/pull/4310#issuecomment-74010582
okey! thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5527] Improvements to standalone doc -e...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4310#issuecomment-73612646
@lazyman500 this seems like a highly specific use case that was intended to be used internally. I bet even most committers for instance don't know about this option. For this reason I would recommend that we close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org