[GitHub] sardell commented on a change in pull request #1307: METRON-1944: Unable to Delete a Comment in Alerts UI

[GitBox <gi...@apache.org>]

sardell commented on a change in pull request #1307: METRON-1944: Unable to Delete a Comment in Alerts UI
URL: https://github.com/apache/metron/pull/1307#discussion_r256447962
 
 

 ##########
 File path: metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
 ##########
 @@ -260,9 +260,7 @@ export class AlertDetailsComponent implements OnInit {
         commentRequest.timestamp = deletedCommentWrapper.alertComment.timestamp;
         commentRequest.sensorType = this.alertSourceType;
         this.updateService.removeComment(commentRequest).subscribe(
-            () => {
-              this.alertCommentsWrapper.map(alertsWrapper => alertsWrapper.alertComment)
-            },
+            null,
 
 Review comment:
   Yeah, that makes sense to remove since we do not know the original intention of the line of code.
   
   @justinleet It looks like this line of code was added here. Is it okay we remove it? Asking because I'm not sure what the original intention of the code was. Since there isn't a PR attached I'm not even sure you were the author of the code: 
   https://github.com/apache/metron/commit/e0fc47582e65e9daf1a0c85dc1b1657166ff14f5#diff-bce5ae5c6be579250a35b6ff4f6da594R271

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services