[GitHub] [beam] henryken commented on a change in pull request #11979: [BEAM-9679] Add Partition task to Core Transform katas

[GitBox <gi...@apache.org>]

henryken commented on a change in pull request #11979:
URL: https://github.com/apache/beam/pull/11979#discussion_r439190971



##########
File path: learning/katas/go/Core Transforms/Partition/Partition/go.mod
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module partition
+
+go 1.14
+
+require (
+	github.com/apache/beam v2.22.0+incompatible

Review comment:
       I realize that we're using multiple versions of Beam, from v2.19 to v2.22.
   Can we standardize to just one version for the entire course?

##########
File path: learning/katas/go/Core Transforms/Partition/Partition/pkg/task/task.go
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package task
+
+import "github.com/apache/beam/sdks/go/pkg/beam"
+
+func ApplyTransform(s beam.Scope, input beam.PCollection) []beam.PCollection {

Review comment:
       Just would like to check whether you intend to have an answer placeholder for the return value?
   In other tasks, we normally don't ask that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org