You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/12/11 14:52:16 UTC

[PR] Add tests for date_part on columns + timestamps with / without timezones [datafusion]

alamb opened a new pull request, #13732:
URL: https://github.com/apache/datafusion/pull/13732

   ## Which issue does this PR close?
   
   
   - Related to https://github.com/apache/datafusion/pull/13372
   
   ## Rationale for this change
   
   
   It wasn't clear to me that there is coverage for date_part with timestamps that are:
   1. Have an explicit, UTC timezone
   2. Have an explicit, non UTC timezone
   
   
   ## What changes are included in this PR?
   
   Add coverage for:
   1. Timestamps an explicit, UTC timezone
   2. Timestamps a, non UTC timezone
   3. Add new tests from https://github.com/apache/datafusion/pull/13372
   
   ## Are these changes tested?
   
   Only tests
   
   ## Are there any user-facing changes?
   No, only tests 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Add tests for date_part on columns + timestamps with / without timezones [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on code in PR #13732:
URL: https://github.com/apache/datafusion/pull/13732#discussion_r1881941848


##########
datafusion/sqllogictest/test_files/expr/date_part.slt:
##########
@@ -876,3 +1070,5 @@ true
 
 query error DataFusion error: Internal error: unit Nanosecond not supported
 SELECT (date_part('nanosecond', now()) = EXTRACT(nanosecond FROM now()))
+
+

Review Comment:
   git encourages against trailing empty lines
   We could add file ending normalization to slt --complete mode.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Add tests for date_part on columns + timestamps with / without timezones [datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #13732:
URL: https://github.com/apache/datafusion/pull/13732#issuecomment-2538830582

   I test with #13372 and all test here pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Add tests for date_part on columns + timestamps with / without timezones [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #13732:
URL: https://github.com/apache/datafusion/pull/13732#discussion_r1882983161


##########
datafusion/sqllogictest/test_files/expr/date_part.slt:
##########
@@ -876,3 +1070,5 @@ true
 
 query error DataFusion error: Internal error: unit Nanosecond not supported
 SELECT (date_part('nanosecond', now()) = EXTRACT(nanosecond FROM now()))
+
+

Review Comment:
   I removed the trailing whitespace in https://github.com/apache/datafusion/pull/13732/commits/bc90fcc1e341f5de60137b0a8997c3e83dadd7e2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Add tests for date_part on columns + timestamps with / without timezones [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13732:
URL: https://github.com/apache/datafusion/pull/13732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org