You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:59:19 UTC
[GitHub] [incubator-shenyu-website] changanjennifer opened a new pull request #240: Add code analysis for PredicateJudge API
changanjennifer opened a new pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240
Add code analysis for PredicateJudge API, add two markdown and 4 images, If the images need to change path, pls let me know.
and Wish to review the english version, some of the technique experssion may not proper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] yu199195 merged pull request #240: Add code analysis for PredicateJudge API
Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] fengzhenbing commented on pull request #240: Add code analysis for PredicateJudge API
Posted by GitBox <gi...@apache.org>.
fengzhenbing commented on pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240#issuecomment-913265747
> hi, @changanjennifer , your code analysis is very good, but there may be a md format error. pleaase see ci and fix it.
Maybe you can try to run `yarn lint --fix` to fix the format error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] changanjennifer commented on pull request #240: Add code analysis for PredicateJudge API
Posted by GitBox <gi...@apache.org>.
changanjennifer commented on pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240#issuecomment-914160516
Hi, Has submit the updated code analysis markdown file. Wish for your review and approval
At 2021-09-03 19:07:00, "midnight2104" ***@***.***> wrote:
hi, @changanjennifer , your code analysis is very good, but there may be a md format error. pleaase see ci and fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] midnight2104 commented on pull request #240: Add code analysis for PredicateJudge API
Posted by GitBox <gi...@apache.org>.
midnight2104 commented on pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240#issuecomment-912455760
hi, @changanjennifer , your code analysis is very good, but there may be a md format error. pleaase see ci and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] changanjennifer commented on pull request #240: Add code analysis for PredicateJudge API
Posted by GitBox <gi...@apache.org>.
changanjennifer commented on pull request #240:
URL: https://github.com/apache/incubator-shenyu-website/pull/240#issuecomment-913451922
Thanks for your kind reminder, but I'm not familiar with lint, so I will try and correct the format error asap.
At 2021-09-06 09:03:49, "fengzhenbing" ***@***.***> wrote:
hi, @changanjennifer , your code analysis is very good, but there may be a md format error. pleaase see ci and fix it.
Maybe you can try to run yarn lint --fix to fix the format error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org