You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/11 14:43:27 UTC
[GitHub] [incubator-dolphinscheduler] codecov-commenter edited a comment on pull request #2955: add http task timeout & test unit
codecov-commenter edited a comment on pull request #2955:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2955#issuecomment-642700956
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=h1) Report
> Merging [#2955](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/87d03798954bebba714a817cf9d76d06defc3ba2&el=desc) will **increase** coverage by `0.39%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2955 +/- ##
============================================
+ Coverage 38.13% 38.53% +0.39%
- Complexity 2620 2656 +36
============================================
Files 436 436
Lines 20079 20085 +6
Branches 2443 2443
============================================
+ Hits 7658 7740 +82
+ Misses 11712 11626 -86
- Partials 709 719 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phinscheduler/common/task/http/HttpParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svaHR0cC9IdHRwUGFyYW1ldGVycy5qYXZh) | `96.00% <100.00%> (+85.47%)` | `16.00 <4.00> (+15.00)` | |
| [...hinscheduler/server/worker/task/http/HttpTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL2h0dHAvSHR0cFRhc2suamF2YQ==) | `44.24% <100.00%> (+44.24%)` | `15.00 <1.00> (+15.00)` | |
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/dolphinscheduler/api/service/LoggerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTG9nZ2VyU2VydmljZS5qYXZh) | `82.60% <0.00%> (-8.70%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `71.42% <0.00%> (-6.35%)` | `14.00% <0.00%> (-1.00%)` | |
| [...inscheduler/common/task/sqoop/SqoopParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svc3Fvb3AvU3Fvb3BQYXJhbWV0ZXJzLmphdmE=) | `74.00% <0.00%> (ø)` | `25.00% <0.00%> (ø%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `53.95% <0.00%> (+2.87%)` | `11.00% <0.00%> (+2.00%)` | |
| [...ache/dolphinscheduler/server/utils/ParamUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1BhcmFtVXRpbHMuamF2YQ==) | `70.73% <0.00%> (+7.31%)` | `10.00% <0.00%> (+1.00%)` | |
| [...dolphinscheduler/server/worker/task/TaskProps.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1Rhc2tQcm9wcy5qYXZh) | `23.17% <0.00%> (+17.07%)` | `11.00% <0.00%> (+7.00%)` | |
| [...lphinscheduler/common/task/AbstractParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svQWJzdHJhY3RQYXJhbWV0ZXJzLmphdmE=) | `72.72% <0.00%> (+27.27%)` | `5.00% <0.00%> (+1.00%)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=footer). Last update [87d0379...751b265](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org