You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Jay357089 <gi...@git.apache.org> on 2016/08/15 09:46:14 UTC
[GitHub] incubator-carbondata pull request #75: [WIP]query exception when decimal col...
GitHub user Jay357089 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/75
[WIP]query exception when decimal column has int int filter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jay357089/incubator-carbondata decimalfilter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit b532f0e4ca33d426e34460a331475f4aff99c8f2
Author: Jay357089 <li...@huawei.com>
Date: 2016-08-15T09:37:05Z
decimalfilter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #75: [CARBONDATA-157]query exception when ...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #75: [CARBONDATA-157]query exception when ...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/75#discussion_r74873068
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterExpressionProcessor.java ---
@@ -215,6 +215,20 @@ private FilterResolverIntf createFilterResolverTree(Expression expressionTree,
AbsoluteTableIdentifier tableIdentifier, Expression intermediateExpression) {
ExpressionType filterExpressionType = expressionTree.getFilterExpressionType();
BinaryExpression currentExpression = null;
+ if (filterExpressionType == ExpressionType.OR || filterExpressionType == ExpressionType.AND) {
+ Expression leftExpression = ((BinaryExpression) expressionTree).getLeft();
+ Expression rightExpression = ((BinaryExpression) expressionTree).getRight();
+ if (!(leftExpression instanceof BinaryExpression ||
+ leftExpression instanceof ConditionalExpression)) {
+ expressionTree = rightExpression;
+ filterExpressionType = rightExpression.getFilterExpressionType();
+ }
+ else if (!(rightExpression instanceof BinaryExpression ||
--- End diff --
Style
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #75: [CARBONDATA-157]query exception when ...
Posted by Jay357089 <gi...@git.apache.org>.
Github user Jay357089 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/75#discussion_r75053060
--- Diff: core/src/main/java/org/apache/carbondata/scan/filter/FilterExpressionProcessor.java ---
@@ -215,6 +215,20 @@ private FilterResolverIntf createFilterResolverTree(Expression expressionTree,
AbsoluteTableIdentifier tableIdentifier, Expression intermediateExpression) {
ExpressionType filterExpressionType = expressionTree.getFilterExpressionType();
BinaryExpression currentExpression = null;
+ if (filterExpressionType == ExpressionType.OR || filterExpressionType == ExpressionType.AND) {
+ Expression leftExpression = ((BinaryExpression) expressionTree).getLeft();
+ Expression rightExpression = ((BinaryExpression) expressionTree).getRight();
+ if (!(leftExpression instanceof BinaryExpression ||
+ leftExpression instanceof ConditionalExpression)) {
+ expressionTree = rightExpression;
+ filterExpressionType = rightExpression.getFilterExpressionType();
+ }
+ else if (!(rightExpression instanceof BinaryExpression ||
--- End diff --
handled
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---