You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:05:39 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #16089: fix: Safari is not showing scroll bars in Explore
michael-s-molina opened a new pull request #16089:
URL: https://github.com/apache/superset/pull/16089
### SUMMARY
Fix https://github.com/apache/superset/issues/16072
@junlincc @jinghua-qa @rusackas
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/128354308-b59a6557-f8bd-4bab-8e1b-70167adc626b.mov
https://user-images.githubusercontent.com/70410625/128354409-dda33190-f0f0-4356-b262-96782e20452d.mov
### TESTING INSTRUCTIONS
See the original issue for instructions.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893565456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16089:
URL: https://github.com/apache/superset/pull/16089#discussion_r683434813
##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -458,7 +459,7 @@ function ExploreViewContainer(props) {
#app {
flex-basis: 100%;
overflow: hidden;
- height: 100vh;
+ height: 100%;
Review comment:
The `#app` should account for `#app-menu` height. That's why I change it to percentage and set the `body` to `100vh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893687776
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893721452
thank you so much for the quick fix!
https://user-images.githubusercontent.com/67837651/128408502-a9d7afbc-7df5-4507-b9f8-f4ffd6366578.mov
looks like the top padding is missing? above the button
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-896039502
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-894371265
@junlincc I'm not able to reproduce as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893721452
thank you so much for the quick fix!
https://user-images.githubusercontent.com/67837651/128408502-a9d7afbc-7df5-4507-b9f8-f4ffd6366578.mov
looks like the top padding is missing? above the button @michael-s-molina
<img width="415" alt="Screen Shot 2021-08-05 at 10 34 27 AM" src="https://user-images.githubusercontent.com/67837651/128417425-5a77c462-0571-4c5a-9c1b-401e64fc864c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-896343980
🏷 2021.31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893693436
@junlincc Ephemeral environment spinning up at http://54.191.154.174:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893721452
thank you so much for the quick fix!
https://user-images.githubusercontent.com/67837651/128408502-a9d7afbc-7df5-4507-b9f8-f4ffd6366578.mov
looks like the top padding is missing? above the button @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893549443
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893462400
# [Codecov](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16089](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e94795) into [master](https://codecov.io/gh/apache/superset/commit/a59d458e415c7f66ed022928768040554ad9f356?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a59d458) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16089 +/- ##
=======================================
Coverage 76.86% 76.86%
=======================================
Files 995 995
Lines 52876 52876
Branches 6720 6720
=======================================
Hits 40645 40645
Misses 12005 12005
Partials 226 226
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.27% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/16089/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.11% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a59d458...2e94795](https://codecov.io/gh/apache/superset/pull/16089?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893721452
thank you so much for the quick fix!
https://user-images.githubusercontent.com/67837651/128408432-6f035ca2-de27-4d85-96f5-efabb4311fa8.mov
looks like the top padding is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-893794492
@junlincc I wasn't able to reproduce this behavior in the test env. Tested in Safari and Chrome. 🤔
https://user-images.githubusercontent.com/70410625/128420570-1a9d165a-49ed-455b-a5f2-7e12f94c8fd2.mov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #16089:
URL: https://github.com/apache/superset/pull/16089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16089: fix: Safari is not showing scroll bars in Explore
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16089:
URL: https://github.com/apache/superset/pull/16089#issuecomment-895929231
@junlincc Can you unblock?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org