You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/03/15 04:11:17 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #24609: Modify ResourceContainedRule.getDataSourceMapper return role info
FlyingZC opened a new pull request, #24609:
URL: https://github.com/apache/shardingsphere/pull/24609
Changes proposed in this pull request:
- Modify ResourceContainedRule.getDataSourceMapper return role info
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24609: Modify ResourceContainedRule.getDataSourceMapper return role info
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24609:
URL: https://github.com/apache/shardingsphere/pull/24609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #24609: Modify ResourceContainedRule.getDataSourceMapper return role info
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on PR #24609:
URL: https://github.com/apache/shardingsphere/pull/24609#issuecomment-1469496744
<img width="935" alt="image" src="https://user-images.githubusercontent.com/19788130/225238978-f0025147-56c1-4ce5-882b-9ab81f9ce022.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24609: Modify ResourceContainedRule.getDataSourceMapper return role info
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24609:
URL: https://github.com/apache/shardingsphere/pull/24609#issuecomment-1469333342
## [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24609](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54c4f00) into [master](https://codecov.io/gh/apache/shardingsphere/commit/39a6fa58c4e757ce9c1644010cf37400a4279382?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39a6fa5) will **increase** coverage by `0.07%`.
> The diff coverage is `49.10%`.
> :exclamation: Current head 54c4f00 differs from pull request most recent head 4be09f0. Consider uploading reports for the commit 4be09f0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24609 +/- ##
============================================
+ Coverage 50.01% 50.08% +0.07%
Complexity 1597 1597
============================================
Files 3330 3335 +5
Lines 54453 54472 +19
Branches 10013 10011 -2
============================================
+ Hits 27235 27283 +48
+ Misses 24790 24761 -29
Partials 2428 2428
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ery/datanode/DatabaseDiscoveryDataNodeBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiZGlzY292ZXJ5L2RhdGFub2RlL0RhdGFiYXNlRGlzY292ZXJ5RGF0YU5vZGVCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...er/ReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGVzcGxpdHRpbmcvY2hlY2tlci9SZWFkd3JpdGVTcGxpdHRpbmdSdWxlQ29uZmlndXJhdGlvbkNoZWNrZXIuamF2YQ==) | `52.77% <0.00%> (ø)` | |
| [...ng/datanode/ReadwriteSplittingDataNodeBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGVzcGxpdHRpbmcvZGF0YW5vZGUvUmVhZHdyaXRlU3BsaXR0aW5nRGF0YU5vZGVCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gsphere/shadow/datanode/ShadowDataNodeBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9kYXRhbm9kZS9TaGFkb3dEYXRhTm9kZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/shardingsphere/shadow/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYWRvdy9ydWxlL1NoYWRvd1J1bGUuamF2YQ==) | `77.64% <0.00%> (ø)` | |
| [...dc/core/connector/SocketSinkImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvY29ubmVjdG9yL1NvY2tldFNpbmtJbXBvcnRlckNvbm5lY3Rvci5qYXZh) | `15.55% <0.00%> (ø)` | |
| [...rdingsphere/data/pipeline/cdc/core/job/CDCJob.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvam9iL0NEQ0pvYi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...phere/data/pipeline/cdc/util/CDCTableRuleUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL3V0aWwvQ0RDVGFibGVSdWxlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../apache/shardingsphere/single/rule/SingleRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3NpbmdsZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaW5nbGUvcnVsZS9TaW5nbGVSdWxlLmphdmE=) | `67.01% <0.00%> (ø)` | |
| [...tor/subscriber/ConfigurationChangedSubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvY29vcmRpbmF0b3Ivc3Vic2NyaWJlci9Db25maWd1cmF0aW9uQ2hhbmdlZFN1YnNjcmliZXIuamF2YQ==) | `64.44% <0.00%> (ø)` | |
| ... and [48 more](https://codecov.io/gh/apache/shardingsphere/pull/24609?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere/pull/24609/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org