You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:54:56 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #606: SUBMARINE-848. Make submarine CR and resources created in the same namespace

MortalHappiness opened a new pull request #606:
URL: https://github.com/apache/submarine/pull/606


   ### What is this PR for?
   
   https://pkg.go.dev/k8s.io/apimachinery@v0.20.4/pkg/apis/meta/v1#OwnerReference
   
   The documentation above says that we should not create cross-namespace ownerReferences but our submarine CR and the resources created by operator are in different namespaces. After discussion with others, we decided to put them in the same namespace temporarily.
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-848
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #606: SUBMARINE-848. Make submarine CR and resources created in the same namespace

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #606:
URL: https://github.com/apache/submarine/pull/606


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org