You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/04/27 07:57:40 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #23839: chore: update bleach
sebastianliebscher opened a new pull request, #23839:
URL: https://github.com/apache/superset/pull/23839
### SUMMARY
Update bleach to latest 6.0.0 version. Also, heads-up on bleach is deprecated and will only receive security fixes. https://github.com/apache/superset/discussions/23838
### TESTING INSTRUCTIONS
`pytest` or `./scripts/tests/run.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar closed pull request #23839: chore: update bleach
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar closed pull request #23839: chore: update bleach
URL: https://github.com/apache/superset/pull/23839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #23839: chore: update bleach
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on PR #23839:
URL: https://github.com/apache/superset/pull/23839#issuecomment-1527578478
superseded by https://github.com/apache/superset/pull/23862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23839: chore: update bleach
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23839:
URL: https://github.com/apache/superset/pull/23839#issuecomment-1525059676
## [Codecov](https://codecov.io/gh/apache/superset/pull/23839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23839](https://codecov.io/gh/apache/superset/pull/23839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41e83c3) into [master](https://codecov.io/gh/apache/superset/commit/5f035499ac747a9b3113d6abedf2ab5c3090aedf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f03549) will **decrease** coverage by `0.15%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 41e83c3 differs from pull request most recent head 76d6d87. Consider uploading reports for the commit 76d6d87 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23839 +/- ##
==========================================
- Coverage 56.76% 56.62% -0.15%
==========================================
Files 1937 1937
Lines 74929 74929
Branches 8133 8133
==========================================
- Hits 42534 42428 -106
- Misses 30311 30417 +106
Partials 2084 2084
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| presto | `52.92% <100.00%> (ø)` | |
| python | `59.12% <100.00%> (-0.30%)` | :arrow_down: |
| unit | `52.81% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/23839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `75.00% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/23839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `64.98% <100.00%> (-0.11%)` | :arrow_down: |
... and [6 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23839/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #23839: chore: update bleach
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #23839:
URL: https://github.com/apache/superset/pull/23839#issuecomment-1527179921
Hi @sebastianliebscher! Thanks for this PR!
But I've prepared a new #23862 PR to use `nh3` lib instead of `bleach`.
Can you review my PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org