You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/20 22:03:38 UTC
[GitHub] [spark] maryannxue commented on pull request #29243: [SPARK-32444][SQL] Infer filters from DPP
maryannxue commented on pull request #29243:
URL: https://github.com/apache/spark/pull/29243#issuecomment-677929857
We don't just apply DPP to any column, right? Shouldn't we check that the inferred filter is applied on partition columns?
In that sense we should fix the DPP rule for it to be apply the same dimension table filter on partition columns from different tables. In other words, the DPP rule itself should generate a filter on `fact_stats.store_id` and another on `code_stats.store_id`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org