[jira] Commented: (WICKET-1041) Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()

["Kent Tong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534546 ] 

Kent Tong commented on WICKET-1041:
-----------------------------------

Why should it be abstract? In Form.java, onSubmit() is abstract but onError is not. This is good because normally people only use onSubmit(). Now AjaxFormSubmitBehavior is inconsistent with Form.

> Fix a TODO for 1.3 at AjaxFormSubmitBehavior.onError()
> ------------------------------------------------------
>
>                 Key: WICKET-1041
>                 URL: https://issues.apache.org/jira/browse/WICKET-1041
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-beta3
>            Reporter: Martin Grigorov
>            Assignee: Igor Vaynberg
>            Priority: Trivial
>             Fix For: 1.3.0-beta4
>
>
> There is the following TODO at org/apache/wicket/ajax/form/AjaxFormSubmitBehavior.onError():
>   /** 
>      * Listener method invoked when the form has been processed and errors occured
>      * 
>      * @param target
>      * 
>      * TODO 1.3: make abstract to be consistent with onsubmit()
>      * 
>      */
>     protected void onError(AjaxRequestTarget target)
>     {   
>     }   
> Should this be done for 1.3 or it will stay like it is now for the next major release ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.