[jira] [Commented] (AIRFLOW-4452) Webserver and Scheduler keep crashing because of slackclient update

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831400#comment-16831400 ] 

ASF GitHub Bot commented on AIRFLOW-4452:
-----------------------------------------

feng-tao commented on pull request #5225: [AIRFLOW-4452] Webserver and Scheduler keep crashing because of slack…
URL: https://github.com/apache/airflow/pull/5225
 
 
   …client update
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4452
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Webserver and Scheduler keep crashing because of slackclient update
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-4452
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4452
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler, webserver
>    Affects Versions: 1.10.1
>            Reporter: Abhishek Ray
>            Assignee: Tao Feng
>            Priority: Blocker
>
> Webserver and Scheduler get into a crash loop if Airflow is installed with slack dependencies.
> Airflow relies on slackclient which released a new major version (2.0.0) today ([https://pypi.org/project/slackclient/#history]). This new version seems to be incompatible with Airflow causing the webserver to get into a crash loop.
> The root cause of the issue is that Airflow doesn't pin requirements for slackclient:
> [https://github.com/apache/airflow/blob/v1-10-stable/setup.py#L229]
> {code:java}
> slack = ['slackclient>=1.0.0']{code}
>  
> This is the exception in the logs due to this error:
>  
> {code:java}
> File "/Users/abhishek.ray/airflow/dags/test_dag.py", line 3, in <module>
>     from airflow.operators import SlackAPIPostOperator
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/airflow/utils/helpers.py", line 372, in __getattr__
>     loaded_attribute = self._load_attribute(attribute)
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/airflow/utils/helpers.py", line 336, in _load_attribute
>     self._loaded_modules[module] = imp.load_module(module, f, filename, description)
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/imp.py", line 235, in load_module
>     return load_source(name, filename, file)
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/imp.py", line 172, in load_source
>     module = _load(spec)
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/airflow/operators/slack_operator.py", line 24, in <module>
>     from airflow.hooks.slack_hook import SlackHook
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/airflow/hooks/slack_hook.py", line 20, in <module>
>     from slackclient import SlackClient
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/slackclient/__init__.py", line 1, in <module>
>     from .client import SlackClient # noqa
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/slackclient/client.py", line 8, in <module>
>     from .server import Server
>   File "/Users/abhishek.ray/.virtualenvs/airflow-test/lib/python3.6/site-packages/slackclient/server.py", line 14, in <module>
>     from websocket import create_connection
> ModuleNotFoundError: No module named 'websocket'
> {code}
>  
>  
> This is how to reproduce this issue:
> Install apache airflow with slack: 
> {code:java}
> pip install apache-airflow[slack]==1.10.1{code}
>  
> Create a DAG which uses *SlackAPIPostOperator*
> {code:java}
> from airflow import DAG
> from airflow.operators.bash_operator import BashOperator
> from airflow.operators import SlackAPIPostOperator
> dag_default_args = {
>     "owner": "airflow",
>     "depends_on_past": False,
>     "start_date": datetime(2019, 4, 22),
>     "email": ["airflow@airflow.com"],
>     "email_on_failure": False,
>     "email_on_retry": False,
>     "retries": 1,
>     "catchup": True,
> }
> dag = DAG("test_dag", default_args=dag_default_args, schedule_interval="@daily")
> BashOperator(task_id="print_date", bash_command="date", dag=dag){code}
>  
> I think the fix should be pretty straightforward to add a max version for slackclient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)