You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Xinyu Liu <xi...@gmail.com> on 2016/11/11 20:25:31 UTC
Re: Review Request 52570: SAMZA-1025: documentation for hdfs system
consumer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52570/#review155740
-----------------------------------------------------------
docs/learn/documentation/versioned/hdfs/consumer.md (line 22)
<https://reviews.apache.org/r/52570/#comment225813>
Please put more details about how to extend it to read other types of records, like which interface to extend. More tech details will be useful to other users.
docs/learn/documentation/versioned/hdfs/consumer.md (line 66)
<https://reviews.apache.org/r/52570/#comment225814>
This looks not that great to the users. Can we put the details here instead of just refering to a JIRA? Since this is user facing docs, please add the complete information.
Another note: the doc doesn't mention the job behavior when end of stream. That needs to be described here in detail too.
docs/learn/documentation/versioned/hdfs/producer.md (line 70)
<https://reviews.apache.org/r/52570/#comment225812>
Seems to me this is weird that the consumer page entrance is from the producer page. I would suggest add the link in versioned/index.html, something like "Reading from HDFS" before the link of "Writing to HDFS"
- Xinyu Liu
On Oct. 5, 2016, 8:54 p.m., Hai Lu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52570/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 8:54 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-1025
> https://issues.apache.org/jira/browse/SAMZA-1025
>
>
> Repository: samza
>
>
> Description
> -------
>
> documentation of hdfs consumer
>
>
> Diffs
> -----
>
> docs/learn/documentation/versioned/hdfs/consumer.md PRE-CREATION
> docs/learn/documentation/versioned/hdfs/producer.md b0e936f5b0a9c945ea7f02bfc2536ef50f017bf6
> docs/learn/documentation/versioned/jobs/configuration-table.html f60cd50fb197423ac3c84fd364bbe4fb3767883e
>
> Diff: https://reviews.apache.org/r/52570/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Hai Lu
>
>