You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2007/02/02 18:06:05 UTC

[jira] Created: (HTTPCLIENT-625) shutdown of MultiThreadedHttpConnectionManager

shutdown of MultiThreadedHttpConnectionManager
----------------------------------------------

                 Key: HTTPCLIENT-625
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-625
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpClient
    Affects Versions: 3.1 Beta 1
            Reporter: Roland Weber
         Assigned To: Roland Weber
             Fix For: 3.1 Final


- declare 'shutdown' attributes volatile
- interrupt cleanup thread to avoid polling
- don't use iterator on WeakHashMap, ConcurrentModificationException
  might be triggered by garbage collection

patch follows


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-625) shutdown of MultiThreadedHttpConnectionManager

Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roland Weber updated HTTPCLIENT-625:
------------------------------------

    Attachment: 2k7-02-02-commons-MTHCM.txt

Here's the patch. Please review carefully, as my development environment for 3.x is not stable.

cheers,
  Roland


> shutdown of MultiThreadedHttpConnectionManager
> ----------------------------------------------
>
>                 Key: HTTPCLIENT-625
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-625
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 3.1 Beta 1
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>             Fix For: 3.1 Final
>
>         Attachments: 2k7-02-02-commons-MTHCM.txt
>
>
> - declare 'shutdown' attributes volatile
> - interrupt cleanup thread to avoid polling
> - don't use iterator on WeakHashMap, ConcurrentModificationException
>   might be triggered by garbage collection
> patch follows

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-625) shutdown of MultiThreadedHttpConnectionManager

Posted by "Michael Becke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469911 ] 

Michael Becke commented on HTTPCLIENT-625:
------------------------------------------

Looks good to me.

Mike

> shutdown of MultiThreadedHttpConnectionManager
> ----------------------------------------------
>
>                 Key: HTTPCLIENT-625
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-625
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 3.1 Beta 1
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>             Fix For: 3.1 Final
>
>         Attachments: 2k7-02-02-commons-MTHCM.txt
>
>
> - declare 'shutdown' attributes volatile
> - interrupt cleanup thread to avoid polling
> - don't use iterator on WeakHashMap, ConcurrentModificationException
>   might be triggered by garbage collection
> patch follows

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-625) shutdown of MultiThreadedHttpConnectionManager

Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469989 ] 

Roland Weber commented on HTTPCLIENT-625:
-----------------------------------------

If I hear no complaints until then, I'll commit the patch tomorrow.

cheers,
  Roland


> shutdown of MultiThreadedHttpConnectionManager
> ----------------------------------------------
>
>                 Key: HTTPCLIENT-625
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-625
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 3.1 Beta 1
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>             Fix For: 3.1 Final
>
>         Attachments: 2k7-02-02-commons-MTHCM.txt
>
>
> - declare 'shutdown' attributes volatile
> - interrupt cleanup thread to avoid polling
> - don't use iterator on WeakHashMap, ConcurrentModificationException
>   might be triggered by garbage collection
> patch follows

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


[jira] Closed: (HTTPCLIENT-625) shutdown of MultiThreadedHttpConnectionManager

Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roland Weber closed HTTPCLIENT-625.
-----------------------------------

    Resolution: Fixed

Patch committed.
There were a few random bytes at the beginning of release_notes.txt which I removed.


> shutdown of MultiThreadedHttpConnectionManager
> ----------------------------------------------
>
>                 Key: HTTPCLIENT-625
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-625
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 3.1 Beta 1
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>             Fix For: 3.1 Final
>
>         Attachments: 2k7-02-02-commons-MTHCM.txt
>
>
> - declare 'shutdown' attributes volatile
> - interrupt cleanup thread to avoid polling
> - don't use iterator on WeakHashMap, ConcurrentModificationException
>   might be triggered by garbage collection
> patch follows

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org