You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/08 22:42:56 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Zha0q1 opened a new pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146
fixes https://github.com/apache/incubator-mxnet/issues/20145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20146: Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#discussion_r611868606
##########
File path: CMakeLists.txt
##########
@@ -980,4 +980,11 @@ if(BUILD_CYTHON_MODULES)
endif()
# https://github.com/apache/incubator-mxnet/issues/20145
-target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
+if(UNIX)
+ if(USE_NVML)
+ find_package(NVML)
+ if(NVML_FOUND)
+ target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
Review comment:
How about moving this to line 595 above and avoid duplication of the nested ifs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20146: Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#discussion_r611973124
##########
File path: CMakeLists.txt
##########
@@ -980,4 +980,11 @@ if(BUILD_CYTHON_MODULES)
endif()
# https://github.com/apache/incubator-mxnet/issues/20145
-target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
+if(UNIX)
+ if(USE_NVML)
+ find_package(NVML)
+ if(NVML_FOUND)
+ target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
Review comment:
You're right. So you can consider add it after line 660, or move 656-660 to an earlier location in the file. It's not necessary to do it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #20146: Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#discussion_r611928255
##########
File path: CMakeLists.txt
##########
@@ -980,4 +980,11 @@ if(BUILD_CYTHON_MODULES)
endif()
# https://github.com/apache/incubator-mxnet/issues/20145
-target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
+if(UNIX)
+ if(USE_NVML)
+ find_package(NVML)
+ if(NVML_FOUND)
+ target_compile_definitions(mxnet PRIVATE NVML_NO_UNVERSIONED_FUNC_DEFS)
Review comment:
I think we need to add this compile def after https://github.com/apache/incubator-mxnet/blob/2cd1b4666d4e6d5df20bc139012061ef0d2e1a37/CMakeLists.txt#L656-L660. In fact I tried what you suggested and got into this error
```
[2021-04-08T23:00:06.226Z] CMake Error at CMakeLists.txt:600 (target_compile_definitions):
[2021-04-08T23:00:06.226Z] Cannot specify compile definitions for target "mxnet" which is not built by
[2021-04-08T23:00:06.226Z] this project.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#issuecomment-816312200
Jenkins CI successfully triggered : [windows-gpu, unix-cpu, website, edge, sanity, unix-gpu, centos-gpu, centos-cpu, clang, miscellaneous, windows-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#issuecomment-816278758
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, clang, website, centos-gpu, unix-gpu, miscellaneous, unix-cpu, sanity, edge, windows-cpu, windows-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#issuecomment-816840078
Jenkins CI successfully triggered : [edge, windows-cpu, miscellaneous, unix-gpu, windows-gpu, website, sanity, unix-cpu, centos-gpu, clang, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #20146: Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#issuecomment-816839968
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #20146: [wip] Define NVML_NO_UNVERSIONED_FUNC_DEFS
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #20146:
URL: https://github.com/apache/incubator-mxnet/pull/20146#issuecomment-816312153
@mxnet-bot run ci [all]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org