You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 18:47:15 UTC
[GitHub] [airflow] potiuk opened a new pull request #20523: Update documentation for provider December 2021 release
potiuk opened a new pull request #20523:
URL: https://github.com/apache/airflow/pull/20523
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775657091
##########
File path: airflow/providers/snowflake/CHANGELOG.rst
##########
@@ -19,6 +19,20 @@
Changelog
---------
+2.4.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Support insecure mode in SnowflakeHook (#20106)``
+* ``Remove unused code in SnowflakeHook (#20107)``
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``Fix MyPy Errors for Snowflake provider. (#20212)``
Review comment:
3 changes that were made to the Snowflake provider are missing but I don't know if this is a problem.
https://github.com/apache/airflow/pull/20245
https://github.com/apache/airflow/pull/20395
https://github.com/apache/airflow/pull/20095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775661683
##########
File path: airflow/providers/snowflake/CHANGELOG.rst
##########
@@ -19,6 +19,20 @@
Changelog
---------
+2.4.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Support insecure mode in SnowflakeHook (#20106)``
+* ``Remove unused code in SnowflakeHook (#20107)``
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``Fix MyPy Errors for Snowflake provider. (#20212)``
Review comment:
Good you noitced. The first 2 are "setup.py" changes and they are not - as such - visible in provider changes. There is currently no link between such "setup.py-only" changes and providers - but we can add them manually. The last one is test-only change and those are not included (and should not be).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775621357
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,56 @@
Changelog
---------
+2.6.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add aws_conn_id to DynamoDBToS3Operator (#20363)``
+* ``Add RedshiftResumeClusterOperator and RedshiftPauseClusterOperator (#19665)``
+* ``Added function in AWSAthenaHook to get s3 output query results file URI (#20124)``
+* ``Add sensor for AWS Batch (#19850) (#19885)``
+* ``Add state details to EMR container failure reason (#19579)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Fix backwards compatibility issue in AWS provider's _get_credentials (#20463)``
+* ``Fix deprecation messages after splitting redshift modules (#20366)``
+* ``ECSOperator: fix KeyError on missing exitCode (#20264)``
+* ``Bug fix in AWS glue operator when specifying the WorkerType & NumberOfWorkers (#19787)``
Review comment:
Not really :). But I can use the #20514 to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#issuecomment-1001702132
So it's too late for https://github.com/apache/airflow/pull/20514 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775617979
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,56 @@
Changelog
---------
+2.6.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add aws_conn_id to DynamoDBToS3Operator (#20363)``
+* ``Add RedshiftResumeClusterOperator and RedshiftPauseClusterOperator (#19665)``
+* ``Added function in AWSAthenaHook to get s3 output query results file URI (#20124)``
+* ``Add sensor for AWS Batch (#19850) (#19885)``
+* ``Add state details to EMR container failure reason (#19579)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Fix backwards compatibility issue in AWS provider's _get_credentials (#20463)``
+* ``Fix deprecation messages after splitting redshift modules (#20366)``
+* ``ECSOperator: fix KeyError on missing exitCode (#20264)``
+* ``Bug fix in AWS glue operator when specifying the WorkerType & NumberOfWorkers (#19787)``
Review comment:
Should it have `&` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775947896
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,56 @@
Changelog
---------
+2.6.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add aws_conn_id to DynamoDBToS3Operator (#20363)``
+* ``Add RedshiftResumeClusterOperator and RedshiftPauseClusterOperator (#19665)``
+* ``Added function in AWSAthenaHook to get s3 output query results file URI (#20124)``
+* ``Add sensor for AWS Batch (#19850) (#19885)``
+* ``Add state details to EMR container failure reason (#19579)``
+
+Bug Fixes
+~~~~~~~~~
+
+* ``Fix backwards compatibility issue in AWS provider's _get_credentials (#20463)``
+* ``Fix deprecation messages after splitting redshift modules (#20366)``
+* ``ECSOperator: fix KeyError on missing exitCode (#20264)``
+* ``Bug fix in AWS glue operator when specifying the WorkerType & NumberOfWorkers (#19787)``
Review comment:
Fixed it permanently (missing "| safe" in Jinja filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20523:
URL: https://github.com/apache/airflow/pull/20523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#discussion_r775948783
##########
File path: airflow/providers/snowflake/CHANGELOG.rst
##########
@@ -19,6 +19,20 @@
Changelog
---------
+2.4.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Support insecure mode in SnowflakeHook (#20106)``
+* ``Remove unused code in SnowflakeHook (#20107)``
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``Fix MyPy Errors for Snowflake provider. (#20212)``
Review comment:
Updated manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#issuecomment-1001710472
> So it's too late for #20514 :)
Not too late . We can add it still. I think it makes sense actually as we have breaking changes there already so we can add this one if we merge it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20523: Update documentation for provider December 2021 release
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20523:
URL: https://github.com/apache/airflow/pull/20523#issuecomment-1001702484
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org