You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/13 15:20:14 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #2132: Allow running the Azure test against the real Azure API in addition to
ppalaga opened a new pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132
local Azurite instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r557350270
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the following:
+
+* An Azure https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-create-account-block-blob?tabs=azure-portal[Storage Account]
Review comment:
There are no specific instructions for queue. The Storage account holds for both. Maybe we should rephrase the readme?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#issuecomment-759709122
32a8e7c:
* Addressed the typo reported by @jamesnetherton
* Upgraded to azurite:3.9.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
llowinge commented on pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#issuecomment-759571991
@ppalaga Thx for the info, i will definitely try it !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r557409348
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the following:
+
+* An Azure https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-create-account-block-blob?tabs=azure-portal[Storage Account]
Review comment:
Thanks, fixed in 58859a2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
llowinge commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r557352017
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the following:
+
+* An Azure https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-create-account-block-blob?tabs=azure-portal[Storage Account]
Review comment:
That is weird, i've followed the readme and only the `testAzureBlobComponent` is passing :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
llowinge commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r557361622
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the following:
+
+* An Azure https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-create-account-block-blob?tabs=azure-portal[Storage Account]
Review comment:
I have it ! One should follow https://docs.microsoft.com/en-us/azure/storage/common/storage-account-create?toc=%2Fazure%2Fstorage%2Fblobs%2Ftoc.json&tabs=azure-portal as it contains also the Queue service.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r556632319
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the follwing:
Review comment:
Thanks, let me fix it when we see that the CI is passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#issuecomment-759517689
@llowinge you may want to review and test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
llowinge commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r557345537
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the following:
+
+* An Azure https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-create-account-block-blob?tabs=azure-portal[Storage Account]
Review comment:
@ppalaga I'm missing instructions for the Queue Storage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #2132: Allow running the Azure test against the real Azure API in addition to
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #2132:
URL: https://github.com/apache/camel-quarkus/pull/2132#discussion_r556602736
##########
File path: integration-tests/azure/README.adoc
##########
@@ -0,0 +1,16 @@
+== Camel Quarkus Azure (deprecated client v8) integration tests
+
+By default the integration tests run against a local https://github.com/Azure/Azurite[Azurite] container.
+
+To run the tests against the real remote Azure API, you need the follwing:
Review comment:
Typo `follwing`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org