You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/06 18:59:02 UTC

[GitHub] [beam] reuvenlax commented on a diff in pull request #24145: Handle updates to table schema when using Storage API writes.

reuvenlax commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1063701364


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -488,6 +542,14 @@ long flush(
               return RetryType.RETRY_ALL_OPERATIONS;
             },
             c -> {
+              AppendRowsResponse response = Preconditions.checkStateNotNull(c.getResult());
+              if (autoUpdateSchema && response.hasUpdatedSchema()) {

Review Comment:
   I don't believe we do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org