You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/08 10:19:37 UTC

[GitHub] [tvm] elvin-n opened a new pull request, #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

elvin-n opened a new pull request, #13321:
URL: https://github.com/apache/tvm/pull/13321

   @AndrewZhaoLuo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] AndrewZhaoLuo merged pull request #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged PR #13321:
URL: https://github.com/apache/tvm/pull/13321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13321:
URL: https://github.com/apache/tvm/pull/13321#issuecomment-1306971535

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `doc` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] echuraev commented on a diff in pull request #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

Posted by GitBox <gi...@apache.org>.
echuraev commented on code in PR #13321:
URL: https://github.com/apache/tvm/pull/13321#discussion_r1016474744


##########
python/tvm/relay/transform/transform.py:
##########
@@ -1349,6 +1349,13 @@ def ToMixedPrecision(mixed_precision_type="float16", missing_op_mode=1):
         1: Allow missing ops but emit warnings.
         2: Allow missing ops and silently ignore them.
 
+    relay.ToMixedPrecision.keep_orig_output_dtype: boolean
+      Defines if outputs should be retained in original data type or convert to
+      mixed_precision_type. By default this parameter is False and transformation
+      modifies the data types of outputs to mixed_precision_type.
+      This parameter is not part of explicit arguments of the transformation, but should
+      be passed through tvm.transform.PassContext.

Review Comment:
   Probably we can add an example of passing this value through `tvm.transform.PassContext` to the description?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] elvin-n commented on a diff in pull request #13321: [Doc] Add desc of keep_orig_output_dtype for ToMixedPrecision

Posted by GitBox <gi...@apache.org>.
elvin-n commented on code in PR #13321:
URL: https://github.com/apache/tvm/pull/13321#discussion_r1016579452


##########
python/tvm/relay/transform/transform.py:
##########
@@ -1349,6 +1349,13 @@ def ToMixedPrecision(mixed_precision_type="float16", missing_op_mode=1):
         1: Allow missing ops but emit warnings.
         2: Allow missing ops and silently ignore them.
 
+    relay.ToMixedPrecision.keep_orig_output_dtype: boolean
+      Defines if outputs should be retained in original data type or convert to
+      mixed_precision_type. By default this parameter is False and transformation
+      modifies the data types of outputs to mixed_precision_type.
+      This parameter is not part of explicit arguments of the transformation, but should
+      be passed through tvm.transform.PassContext.

Review Comment:
   If we consider this as regular approach of passing parameters, then we don't need to have such example in every and each place of their usages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org