You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Jake Maes (JIRA)" <ji...@apache.org> on 2018/01/25 21:33:00 UTC

[jira] [Resolved] (SAMZA-1345) Samza REST: ScriptRunner should better manage environment variables.

     [ https://issues.apache.org/jira/browse/SAMZA-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Maes resolved SAMZA-1345.
------------------------------
       Resolution: Fixed
    Fix Version/s: 0.13.1

This was done in SAMZA-1366

> Samza REST: ScriptRunner should better manage environment variables.
> --------------------------------------------------------------------
>
>                 Key: SAMZA-1345
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1345
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Jake Maes
>            Assignee: Jake Maes
>            Priority: Major
>             Fix For: 0.13.1
>
>
> The ScriptRunner class used in Samza REST uses ProcessBuilder to execute scripts for job start/stop/status as well as various other operations. 
> ProcessBuilder, by default, forwards all environment variables from the parent process to the spawned process and this can cause unexpected behaviors. 
> For example, if samza rest configures one type of log4j configuration, the script invoked on that job will use the same configuration, even if the job expects a different configuration. 
> The minimum requirement for this ticket is to clear the environment variables using 
> `processBuilder.environment().clear()`
> Even better, we could provide some mechanism in the ScriptRunner to set specific environment variables. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)