You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2024/09/23 18:00:37 UTC
(hop) branch main updated: oracle bulk loader fixes #4322 (#4325)
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new e9ea54d9a4 oracle bulk loader fixes #4322 (#4325)
e9ea54d9a4 is described below
commit e9ea54d9a4fa88369f0fad4586fbd091fa0bf9cd
Author: Bart Maertens <ba...@know.bi>
AuthorDate: Mon Sep 23 20:00:31 2024 +0200
oracle bulk loader fixes #4322 (#4325)
* fix missing connection line. #4322
* fix NPE in SQL statements. #4322
* fix incorrect SQL Loader command. #4322
* oracle docker compose initial version. #4322
* removed oracle docker compose placeholder. #4322
---
.../apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java | 2 +-
.../hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java | 3 ++-
.../hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java | 3 +--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java
index b1a2011450..3d64834fdc 100644
--- a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java
+++ b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoader.java
@@ -438,7 +438,7 @@ public class OraBulkLoader extends BaseTransform<OraBulkLoaderMeta, OraBulkLoade
databaseName = '"' + databaseName + '"';
}
- sb.append(databaseName);
+ sb.append("/" + databaseName);
} else {
throw new HopException("No connection specified");
}
diff --git a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java
index af91a6e75d..2b264493e7 100644
--- a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java
+++ b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderDialog.java
@@ -234,7 +234,8 @@ public class OraBulkLoaderDialog extends BaseTransformDialog {
};
// Connection line
- wConnection = addConnectionLine(shell, wTransformName, input.getConnection(), lsMod);
+ wConnection =
+ addConnectionLine(wBulkLoaderComposite, wTransformName, input.getConnection(), lsMod);
wConnection.addSelectionListener(lsSelection);
// Schema line...
diff --git a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java
index 675ba91471..d165623683 100644
--- a/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java
+++ b/plugins/transforms/orabulkloader/src/main/java/org/apache/hop/pipeline/transforms/orabulkloader/OraBulkLoaderMeta.java
@@ -546,8 +546,7 @@ public class OraBulkLoaderMeta extends BaseTransformMeta<OraBulkLoader, OraBulkL
IHopMetadataProvider metadataProvider)
throws HopTransformException {
- DatabaseMeta databaseMeta =
- getParentTransformMeta().getParentPipelineMeta().findDatabase(connection, variables);
+ DatabaseMeta databaseMeta = pipelineMeta.findDatabase(connection, variables);
SqlStatement retval =
new SqlStatement(transformMeta.getName(), databaseMeta, null); // default: nothing to do!